Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc

Issue 2479553006: Remove GetWindowList / GetScreenList and SelectWindow / SelectScreen from WebRTC (Closed)
Patch Set: Resolve review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc
diff --git a/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc b/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc
index 451acb3db5ed80621b19652f97b272416fb73eaa..4035cbf0d1fffd69b9963c3027d5ebfbb84b8870 100644
--- a/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc
+++ b/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc
@@ -157,9 +157,8 @@ CGWindowID FullScreenChromeWindowDetector::FindFullScreenWindow(
if (full_screen_window_id == kCGNullWindowID)
return kCGNullWindowID;
- for (WindowCapturer::WindowList::iterator it = previous_window_list_.begin();
- it != previous_window_list_.end(); ++it) {
- if (static_cast<CGWindowID>(it->id) != full_screen_window_id)
+ for (const auto& window : previous_window_list_) {
+ if (static_cast<CGWindowID>(window.id) != full_screen_window_id)
continue;
LOG(LS_WARNING) << "The full-screen window exists in the list.";
@@ -183,7 +182,7 @@ void FullScreenChromeWindowDetector::UpdateWindowListIfNeeded(
return;
}
- GetWindowList(&current_window_list_);
+ GetWindowList(&current_window_list_, false);
last_update_time_ns_ = rtc::TimeNanos();
}
}

Powered by Google App Engine
This is Rietveld 408576698