Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webrtc/modules/desktop_capture/cropping_window_capturer.h

Issue 2479553006: Remove GetWindowList / GetScreenList and SelectWindow / SelectScreen from WebRTC (Closed)
Patch Set: Resolve review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/desktop_capture/cropping_window_capturer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 public: 27 public:
28 static WindowCapturer* Create(const DesktopCaptureOptions& options); 28 static WindowCapturer* Create(const DesktopCaptureOptions& options);
29 ~CroppingWindowCapturer() override; 29 ~CroppingWindowCapturer() override;
30 30
31 // DesktopCapturer implementation. 31 // DesktopCapturer implementation.
32 void Start(DesktopCapturer::Callback* callback) override; 32 void Start(DesktopCapturer::Callback* callback) override;
33 void SetSharedMemoryFactory( 33 void SetSharedMemoryFactory(
34 std::unique_ptr<SharedMemoryFactory> shared_memory_factory) override; 34 std::unique_ptr<SharedMemoryFactory> shared_memory_factory) override;
35 void CaptureFrame() override; 35 void CaptureFrame() override;
36 void SetExcludedWindow(WindowId window) override; 36 void SetExcludedWindow(WindowId window) override;
37 37 bool GetSourceList(SourceList* sources) override;
38 // WindowCapturer implementation. 38 bool SelectSource(SourceId id) override;
39 bool GetWindowList(WindowList* windows) override; 39 bool FocusOnSelectedSource() override;
40 bool SelectWindow(WindowId id) override;
41 bool BringSelectedWindowToFront() override;
42 40
43 // DesktopCapturer::Callback implementation, passed to |screen_capturer_| to 41 // DesktopCapturer::Callback implementation, passed to |screen_capturer_| to
44 // intercept the capture result. 42 // intercept the capture result.
45 void OnCaptureResult(DesktopCapturer::Result result, 43 void OnCaptureResult(DesktopCapturer::Result result,
46 std::unique_ptr<DesktopFrame> frame) override; 44 std::unique_ptr<DesktopFrame> frame) override;
47 45
48 protected: 46 protected:
49 explicit CroppingWindowCapturer(const DesktopCaptureOptions& options); 47 explicit CroppingWindowCapturer(const DesktopCaptureOptions& options);
50 48
51 // The platform implementation should override these methods. 49 // The platform implementation should override these methods.
52 50
53 // Returns true if it is OK to capture the whole screen and crop to the 51 // Returns true if it is OK to capture the whole screen and crop to the
54 // selected window, i.e. the selected window is opaque, rectangular, and not 52 // selected window, i.e. the selected window is opaque, rectangular, and not
55 // occluded. 53 // occluded.
56 virtual bool ShouldUseScreenCapturer() = 0; 54 virtual bool ShouldUseScreenCapturer() = 0;
57 55
58 // Returns the window area relative to the top left of the virtual screen 56 // Returns the window area relative to the top left of the virtual screen
59 // within the bounds of the virtual screen. 57 // within the bounds of the virtual screen.
60 virtual DesktopRect GetWindowRectInVirtualScreen() = 0; 58 virtual DesktopRect GetWindowRectInVirtualScreen() = 0;
61 59
62 WindowId selected_window() const { return selected_window_; } 60 WindowId selected_window() const { return selected_window_; }
63 WindowId excluded_window() const { return excluded_window_; } 61 WindowId excluded_window() const { return excluded_window_; }
64 62
65 private: 63 private:
66 DesktopCaptureOptions options_; 64 DesktopCaptureOptions options_;
67 DesktopCapturer::Callback* callback_; 65 DesktopCapturer::Callback* callback_;
68 std::unique_ptr<WindowCapturer> window_capturer_; 66 std::unique_ptr<WindowCapturer> window_capturer_;
69 std::unique_ptr<ScreenCapturer> screen_capturer_; 67 std::unique_ptr<ScreenCapturer> screen_capturer_;
70 WindowId selected_window_; 68 SourceId selected_window_;
71 WindowId excluded_window_; 69 WindowId excluded_window_;
72 }; 70 };
73 71
74 } // namespace webrtc 72 } // namespace webrtc
75 73
76 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_ 74 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_CROPPING_WINDOW_CAPTURER_H_
77 75
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/desktop_capture/cropping_window_capturer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698