Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2479543003: Add new Chrome signing/diff scripts to build configs. (Closed)

Created:
4 years, 1 month ago by Michael Moss
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, mac-reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new Chrome signing/diff scripts to build configs. R=mark@chromium.org BUG=660598 Committed: https://crrev.com/f1b58e59add1ada98d78b6b883da1952e0712fd5 Cr-Commit-Position: refs/heads/master@{#430067}

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/installer/mac/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Moss
4 years, 1 month ago (2016-11-04 04:32:03 UTC) #1
Mark Mentovai
Holding until the other one is ready to go, please ping me if I forget ...
4 years, 1 month ago (2016-11-04 13:40:22 UTC) #2
Michael Moss
Updated with the renamed include file. PTAL.
4 years, 1 month ago (2016-11-04 17:30:13 UTC) #3
Mark Mentovai
LGTM
4 years, 1 month ago (2016-11-04 21:13:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479543003/20001
4 years, 1 month ago (2016-11-04 21:53:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 23:31:30 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 23:35:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1b58e59add1ada98d78b6b883da1952e0712fd5
Cr-Commit-Position: refs/heads/master@{#430067}

Powered by Google App Engine
This is Rietveld 408576698