chrome/common/extensions/ad_injection_constants.cc - Issue 247953008: Extend DOMActivityLogger interface for upcoming change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/ad_injection_constants.cc

Issue 247953008: Extend DOMActivityLogger interface for upcoming change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/ad_injection_constants.cc

diff --git a/chrome/common/extensions/ad_injection_constants.cc b/chrome/common/extensions/ad_injection_constants.cc

index 6cdea9733e2ef21ec8106552dfa62e75e5d8d415..0565946b0190f63774819f1d7ca0403e0a8e1b11 100644

--- a/chrome/common/extensions/ad_injection_constants.cc

+++ b/chrome/common/extensions/ad_injection_constants.cc

@@ -29,7 +29,7 @@ extern const size_t kMaximumChildrenToCheck = 10u;

// The maximum depth to check when we examine a newly-added element.

extern const size_t kMaximumDepthToCheck = 5u;

-bool ApiCanInjectAds(const char* api) {

+bool ApiCanInjectAds(const std::string& api) {

return api == kHtmlIframeSrcApiName ||

api == kHtmlEmbedSrcApiName ||

EndsWith(api, kAppendChildApiSuffix, true /* case sensitive */);