test/cctest/test-strings.cc - Issue 247953003: Tiny cleanup.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/test-strings.cc

Issue 247953003: Tiny cleanup. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2012 the V8 project authors. All rights reserved.	1 // Copyright 2012 the V8 project authors. All rights reserved.

2 // Redistribution and use in source and binary forms, with or without	2 // Redistribution and use in source and binary forms, with or without

3 // modification, are permitted provided that the following conditions are	3 // modification, are permitted provided that the following conditions are

4 // met:	4 // met:

5 //	5 //

6 // * Redistributions of source code must retain the above copyright	6 // * Redistributions of source code must retain the above copyright

7 // notice, this list of conditions and the following disclaimer.	7 // notice, this list of conditions and the following disclaimer.

8 // * Redistributions in binary form must reproduce the above	8 // * Redistributions in binary form must reproduce the above

9 // copyright notice, this list of conditions and the following	9 // copyright notice, this list of conditions and the following

10 // disclaimer in the documentation and/or other materials provided	10 // disclaimer in the documentation and/or other materials provided

(...skipping 1400 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1411 CHECK(isolate->factory()->FUN(Vector<const TYPE>::cast(dummy)).is_null()); \	1411 CHECK(isolate->factory()->FUN(Vector<const TYPE>::cast(dummy)).is_null()); \

1412 memset(dummy.start(), 0x20, dummy.length() * sizeof(TYPE)); \	1412 memset(dummy.start(), 0x20, dummy.length() * sizeof(TYPE)); \

1413 CHECK(isolate->has_pending_exception()); \	1413 CHECK(isolate->has_pending_exception()); \

1414 isolate->clear_pending_exception(); \	1414 isolate->clear_pending_exception(); \

1415 dummy.Dispose(); \	1415 dummy.Dispose(); \

1416 }	1416 }

1417	1417

1418 INVALID_STRING_TEST(NewStringFromAscii, char)	1418 INVALID_STRING_TEST(NewStringFromAscii, char)

1419 INVALID_STRING_TEST(NewStringFromUtf8, char)	1419 INVALID_STRING_TEST(NewStringFromUtf8, char)

1420 INVALID_STRING_TEST(NewStringFromOneByte, uint8_t)	1420 INVALID_STRING_TEST(NewStringFromOneByte, uint8_t)

1421 INVALID_STRING_TEST(InternalizeOneByteString, uint8_t)

1422 INVALID_STRING_TEST(InternalizeUtf8String, char)

1423	1421

1424 #undef INVALID_STRING_TEST	1422 #undef INVALID_STRING_TEST

OLD	NEW