Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 247953003: Tiny cleanup. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL
6 years, 8 months ago (2014-04-23 19:10:28 UTC) #1
Igor Sheludko
Please ignore this for now, it fails on cctest/test-strings/StringOOMInternalizeUtf8String
6 years, 8 months ago (2014-04-23 19:27:31 UTC) #2
Yang
On 2014/04/23 19:27:31, Igor Sheludko wrote: > Please ignore this for now, it fails on ...
6 years, 8 months ago (2014-04-24 06:59:41 UTC) #3
Igor Sheludko
6 years, 8 months ago (2014-04-24 08:35:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698