Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-3.html

Issue 2479483002: Properly avoid breaking inside a float's top margin. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fragmentation/float-margin-top.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-3.html
diff --git a/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html b/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-3.html
similarity index 59%
copy from third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html
copy to third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-3.html
index e2a6bd98183ac72a0b221941e5d7ec4afc7a575a..7a72e112e016f351b8ea195989232ca0b9798a48 100644
--- a/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html
+++ b/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-3.html
@@ -1,11 +1,9 @@
<!DOCTYPE html>
<p>There should be a cyan square in the bottom right corner of a blue rectangle.</p>
-<div id="multicol" style="position:relative; columns:3; line-height:20px; orphans:1; widows:1; background:blue;">
+<div id="multicol" style="position:relative; columns:3; width:150px; line-height:20px; orphans:1; widows:1; background:blue;">
<br>
<br>
- <br>
- <br>
- <div id="elm" style="float:right; margin-top:30px; width:40px; line-height:40px; background:cyan;">
+ <div id="elm" style="float:right; margin-top:10px; width:20px; background:cyan;">
<br>
</div>
</div>
@@ -15,7 +13,7 @@
test(() => {
var multicol = document.getElementById("multicol");
var elm = document.getElementById("elm");
- assert_equals(multicol.offsetHeight, 70);
- assert_equals(elm.offsetTop, 30);
+ assert_equals(multicol.offsetHeight, 30);
+ assert_equals(elm.offsetTop, 10);
}, "Float that should fit its top margin together with the border box.");
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fragmentation/float-margin-top.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698