Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2479463004: Fix java target naming exceptions in device/ and components/policy (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix java target naming exceptions in device/ and components/policy BUG=620034 Committed: https://crrev.com/45e3b18b7312c37abd86c300d045b5e43ea1ec72 Cr-Commit-Position: refs/heads/master@{#429977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M device/battery/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/vibration/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
agrieve
🐸
4 years, 1 month ago (2016-11-03 15:19:29 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-03 15:22:12 UTC) #5
boliu
lgtm
4 years, 1 month ago (2016-11-03 16:49:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479463004/1
4 years, 1 month ago (2016-11-03 17:17:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/310466)
4 years, 1 month ago (2016-11-03 20:18:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479463004/1
4 years, 1 month ago (2016-11-04 16:47:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 19:30:40 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 20:00:19 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/45e3b18b7312c37abd86c300d045b5e43ea1ec72
Cr-Commit-Position: refs/heads/master@{#429977}

Powered by Google App Engine
This is Rietveld 408576698