Issue 2479463003: DBC: Fix fast-path allocation with type arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2479463003: DBC: Fix fast-path allocation with type arguments (Closed)

Created:
4 years, 1 month ago by Florian Schneider

Modified:
4 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google), zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

DBC: Fix fast-path allocation with type arguments The type arguments were overwritten with null -- move their initialization to the end instead. Fixes #27733. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/3c6d13c33eeca96d25c62091bbe9a7e27e5d85a4

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	runtime/vm/simulator_dbc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/language/language.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (3 generated)

Florian Schneider

4 years, 1 month ago (2016-11-03 13:52:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3c6d13c33eeca96d25c62091bbe9a7e27e5d85a4 (presubmit successful).