Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: ui/message_center/message_center.gyp

Issue 247943003: Allow compiling Android with notifications=1, add stubbed UI manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center.gyp
diff --git a/ui/message_center/message_center.gyp b/ui/message_center/message_center.gyp
index 7a5bdd293be821519bb2ab34cfba88c1949797eb..8812eb996da5bd004ad899106077026bb9c2288d 100644
--- a/ui/message_center/message_center.gyp
+++ b/ui/message_center/message_center.gyp
@@ -132,7 +132,9 @@
'views/message_popup_bubble.h',
],
}],
- ['notifications==0', { # Android and iOS.
+ # iOS disables notifications altogether, Android implements its own
+ # notification UI manager instead of deferring to the message center.
+ ['notifications==0 or OS=="android"', {
'sources/': [
# Exclude everything except dummy impl.
['exclude', '\\.(cc|mm)$'],
@@ -142,6 +144,14 @@
}, { # notifications==1
'sources!': [ 'dummy_message_center.cc' ],
}],
+ # Include a minimal set of files required for notifications on Android.
+ ['OS=="android"', {
+ 'sources/': [
+ ['include', '^notification\\.cc$'],
+ ['include', '^notification_delegate\\.cc$'],
+ ['include', '^notifier_settings\\.cc$'],
+ ],
+ }],
],
}, # target_name: message_center
{
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698