Allow compiling Android with notifications=1, add stubbed UI manager

chrome/browser/notifications/notification_ui_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_ui_manager.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/message_center_notification_manager.h"

[dewittj, 2014/04/22 19:03:18]

do you need to exclude these lines if Android is defined?

[Peter Beverloo, 2014/04/22 19:24:10]

It would be cleaner, but since it'll add a lot of noise (three include blocks
rather than two), the file is very small and the code is #ifdef'd out anyway, I
don't think this does a lot of harm.

Happy to move them out if you prefer!

[stevenjb, 2014/04/22 20:26:39]

I think this is fine as-is, but if we do change it, rather than creating another
#ifdef block, I would simply move Create() to notification_ui_manager_android.cc
and eliminate this file from the android build entirely (and maybe rename it
notification_ui_manager_desktop.cc).

[Peter Beverloo, 2014/04/29 15:46:19]

Good idea, thanks! Done.

 #include "chrome/browser/notifications/message_center_settings_controller.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "ui/message_center/message_center_util.h"
 
+#if defined(OS_ANDROID)
+#include "chrome/browser/notifications/notification_ui_manager_android.h"
+#endif
+
 // static
 NotificationUIManager* NotificationUIManager::Create(PrefService* local_state) {
+#if defined(OS_ANDROID)
+  // Chrome for Android defers to the Android framework for displaying
+  // notifications, and thus doesn't use the message center.
+  return new NotificationUIManagerAndroid();
+#else
   ProfileInfoCache* profile_info_cache =
       &g_browser_process->profile_manager()->GetProfileInfoCache();
   scoped_ptr<message_center::NotifierSettingsProvider> settings_provider(
       new MessageCenterSettingsController(profile_info_cache));
   return new MessageCenterNotificationManager(
       g_browser_process->message_center(),
       local_state,
       settings_provider.Pass());
+#endif
 }