Use template parameter to reduce branching in style resolve apply passes

third_party/WebKit/Source/core/css/resolver/StyleResolver.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
  * All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 201 matching lines @@
 
   void applyMatchedProperties(StyleResolverState&, const MatchResult&);
   bool applyAnimatedProperties(StyleResolverState&,
                                const Element* animatingElement);
   void applyCallbackSelectors(StyleResolverState&);
 
   // These flags indicate whether an apply pass for a given CSSPropertyPriority
   // and isImportant is required.
   class NeedsApplyPass {
    public:
-    bool needsUpdate() const { return m_needsUpdate; }
-    bool setNeedsUpdate(bool needsUpdate) {
-      return m_needsUpdate = needsUpdate;
-    }
     bool get(CSSPropertyPriority priority, bool isImportant) const {
-      DCHECK(!needsUpdate());
       return m_flags[getIndex(priority, isImportant)];
     }
     void set(CSSPropertyPriority priority, bool isImportant) {
-      DCHECK(needsUpdate());
       m_flags[getIndex(priority, isImportant)] = true;
     }
 
    private:
     static size_t getIndex(CSSPropertyPriority priority, bool isImportant) {
       DCHECK(priority >= 0 && priority < PropertyPriorityCount);
       return priority * 2 + isImportant;
     }
-    bool m_needsUpdate = true;
     bool m_flags[PropertyPriorityCount * 2] = {0};
   };
 
-  template <CSSPropertyPriority priority>
+  enum ShouldUpdateNeedsApplyPass {
+    CheckNeedsApplyPass = false,
+    UpdateNeedsApplyPass = true,
+  };
+
+  template <CSSPropertyPriority priority, ShouldUpdateNeedsApplyPass>
   void applyMatchedProperties(StyleResolverState&,
                               const MatchedPropertiesRange&,
                               bool important,
                               bool inheritedOnly,
                               NeedsApplyPass&);
-  template <CSSPropertyPriority priority>
+  template <CSSPropertyPriority priority, ShouldUpdateNeedsApplyPass>
   void applyProperties(StyleResolverState&,
                        const StylePropertySet* properties,
                        bool isImportant,
                        bool inheritedOnly,
                        NeedsApplyPass&,
                        PropertyWhitelistType = PropertyWhitelistNone);
   template <CSSPropertyPriority priority>
   void applyAnimatedProperties(StyleResolverState&,
                                const ActiveInterpolationsMap&);
   template <CSSPropertyPriority priority>
   void applyAllProperty(StyleResolverState&,
                         const CSSValue&,
                         bool inheritedOnly,
                         PropertyWhitelistType);
-  template <CSSPropertyPriority priority>
+  template <CSSPropertyPriority priority, ShouldUpdateNeedsApplyPass>
   void applyPropertiesForApplyAtRule(StyleResolverState&,
                                      const CSSValue&,
                                      bool isImportant,
                                      NeedsApplyPass&,
                                      PropertyWhitelistType);
 
   bool pseudoStyleForElementInternal(Element&,
                                      const PseudoStyleRequest&,
                                      const ComputedStyle* parentStyle,
                                      StyleResolverState&);
@@ skipping 22 matching lines @@
   bool m_printMediaType;
 
   unsigned m_styleSharingDepth;
   HeapVector<Member<StyleSharingList>, styleSharingMaxDepth>
       m_styleSharingLists;
 };
 
 }  // namespace blink
 
 #endif  // StyleResolver_h