Chromium Code Reviews
DescriptionRevert of Window prerequisites for ShelfWindowWatcher panel support. (patchset #5 id:80001 of https://codereview.chromium.org/2480713003/ )
Reason for revert:
This CL breaks the ARC launch.
The problematic part was
void ShellSurface::SetApplicationId(const std::string& application_id) {
SetApplicationId(widget_->GetNativeWindow(), application_id);
}
where |widget_| can be null.
BUG=b/32718618
TEST=Made sure ARC starts on local dev env.
Original issue's description:
> Window prerequisites for ShelfWindowWatcher panel support.
>
> Prerequisites for https://codereview.chromium.org/2462753002
>
> Split the aura window icon property into window and app icons.
> Add an aura window property of the string application id.
> Use aura::client::kAppId for exo ShellSurface remove local copy.
>
> Add WmWindow string properties; icon getters; attention bool.
> (WmWindowMus not implemented, as per ongoing mus-aura work)
> Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)
>
> BUG=557406
> TEST=Existing unit tests; more tested usage forthcoming.
> R=sky@chromium.org,reveman@chromium.org
>
> Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642
> Cr-Commit-Position: refs/heads/master@{#430182}
TBR=reveman@chromium.org,sky@chromium.org,msw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=557406
Committed: https://crrev.com/480b38130ec990c9cf0d769b608f04f75a2851da
Cr-Commit-Position: refs/heads/master@{#430477}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|