Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2479353003: Revert of Window prerequisites for ShelfWindowWatcher panel support. (Closed)

Created:
4 years, 1 month ago by hidehiko
Modified:
4 years, 1 month ago
Reviewers:
msw, reveman, sky
CC:
chromium-reviews, feature-media-reviews_chromium.org, kalyank, mcasas+watch+vc_chromium.org, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Window prerequisites for ShelfWindowWatcher panel support. (patchset #5 id:80001 of https://codereview.chromium.org/2480713003/ ) Reason for revert: This CL breaks the ARC launch. The problematic part was void ShellSurface::SetApplicationId(const std::string& application_id) { SetApplicationId(widget_->GetNativeWindow(), application_id); } where |widget_| can be null. BUG=b/32718618 TEST=Made sure ARC starts on local dev env. Original issue's description: > Window prerequisites for ShelfWindowWatcher panel support. > > Prerequisites for https://codereview.chromium.org/2462753002 > > Split the aura window icon property into window and app icons. > Add an aura window property of the string application id. > Use aura::client::kAppId for exo ShellSurface remove local copy. > > Add WmWindow string properties; icon getters; attention bool. > (WmWindowMus not implemented, as per ongoing mus-aura work) > Add WmWindow::MoveToEventRoot helper. (like ash::wm helper) > > BUG=557406 > TEST=Existing unit tests; more tested usage forthcoming. > R=sky@chromium.org,reveman@chromium.org > > Committed: https://crrev.com/2d1743732459e03d3a91b007e5b16dca8fa86642 > Cr-Commit-Position: refs/heads/master@{#430182} TBR=reveman@chromium.org,sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=557406 Committed: https://crrev.com/480b38130ec990c9cf0d769b608f04f75a2851da Cr-Commit-Position: refs/heads/master@{#430477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -165 lines) Patch
M ash/aura/wm_window_aura.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 5 chunks +0 lines, -43 lines 0 comments Download
M ash/common/test/test_shelf_item_delegate.cc View 2 chunks +24 lines, -1 line 0 comments Download
M ash/common/wm_window.h View 3 chunks +0 lines, -10 lines 0 comments Download
M ash/common/wm_window_property.h View 2 chunks +0 lines, -13 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 4 chunks +0 lines, -39 lines 0 comments Download
M chrome/browser/media/webrtc/window_icon_util_chromeos.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/exo/shell_surface.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/aura/client/aura_constants.h View 3 chunks +1 line, -9 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hidehiko
Created Revert of Window prerequisites for ShelfWindowWatcher panel support.
4 years, 1 month ago (2016-11-08 01:02:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479353003/1
4 years, 1 month ago (2016-11-08 01:03:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 02:08:08 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 02:10:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/480b38130ec990c9cf0d769b608f04f75a2851da
Cr-Commit-Position: refs/heads/master@{#430477}

Powered by Google App Engine
This is Rietveld 408576698