Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5939)

Unified Diff: chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

Issue 2479313004: [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
index 0f99199245b81c5f562d2275a2059808a4bc9010..43b9df830cd323853062cf257954d0e058d09163 100644
--- a/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
+++ b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
@@ -10,11 +10,13 @@
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/sync/test/integration/typed_urls_helper.h"
#include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "components/browser_sync/profile_sync_service.h"
#include "components/history/core/browser/history_types.h"
#include "components/sessions/core/session_types.h"
#include "components/sync/base/time.h"
+#include "components/sync/driver/sync_driver_switches.h"
#include "components/sync/test/fake_server/fake_server_verifier.h"
#include "components/sync/test/fake_server/sessions_hierarchy.h"
@@ -36,6 +38,18 @@ class SingleClientSessionsSyncTest : public SyncTest {
SingleClientSessionsSyncTest() : SyncTest(SINGLE_CLIENT) {}
~SingleClientSessionsSyncTest() override {}
+ void SetUpCommandLine(base::CommandLine* cl) override {
+ // This is a hacky override of the switches set in
+ // SyncTest::SetUpCommandLine() to avoid the switch that speeds up nudge
+ // delays. CookieJarMismatch asserts exact histogram counts assuming that
+ // sync is relatively slow, so we preserve that assumption.
+ if (!cl->HasSwitch(switches::kDisableBackgroundNetworking))
+ cl->AppendSwitch(switches::kDisableBackgroundNetworking);
+
+ if (!cl->HasSwitch(switches::kSyncShortInitialRetryOverride))
+ cl->AppendSwitch(switches::kSyncShortInitialRetryOverride);
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(SingleClientSessionsSyncTest);
};
« no previous file with comments | « chrome/browser/sync/test/integration/bookmarks_helper.cc ('k') | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698