Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Side by Side Diff: components/sync/engine/engine_components_factory.h

Issue 2479313004: [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_ENGINE_ENGINE_COMPONENTS_FACTORY_H_ 5 #ifndef COMPONENTS_SYNC_ENGINE_ENGINE_COMPONENTS_FACTORY_H_
6 #define COMPONENTS_SYNC_ENGINE_ENGINE_COMPONENTS_FACTORY_H_ 6 #define COMPONENTS_SYNC_ENGINE_ENGINE_COMPONENTS_FACTORY_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 enum PreCommitUpdatesPolicy { 49 enum PreCommitUpdatesPolicy {
50 // By default, the server will enable or disable this experiment through the 50 // By default, the server will enable or disable this experiment through the
51 // sync protocol's experiments data type. 51 // sync protocol's experiments data type.
52 SERVER_CONTROLLED_PRE_COMMIT_UPDATE_AVOIANCE, 52 SERVER_CONTROLLED_PRE_COMMIT_UPDATE_AVOIANCE,
53 53
54 // This flag overrides the server's decision and enables the pre-commit 54 // This flag overrides the server's decision and enables the pre-commit
55 // update avoidance experiment. 55 // update avoidance experiment.
56 FORCE_ENABLE_PRE_COMMIT_UPDATE_AVOIDANCE, 56 FORCE_ENABLE_PRE_COMMIT_UPDATE_AVOIDANCE,
57 }; 57 };
58 58
59 enum class NudgeDelay {
60 DEFAULT_NUDGE_DELAY,
61 SHORT_NUDGE_DELAY,
62 };
63
59 // Configuration options for internal components. This struct is expected 64 // Configuration options for internal components. This struct is expected
60 // to grow and shrink over time with transient features / experiments, 65 // to grow and shrink over time with transient features / experiments,
61 // roughly following command line flags in chrome. Implementations of 66 // roughly following command line flags in chrome. Implementations of
62 // EngineComponentsFactory can use this information to build components 67 // EngineComponentsFactory can use this information to build components
63 // with appropriate bells and whistles. 68 // with appropriate bells and whistles.
64 struct Switches { 69 struct Switches {
65 EncryptionMethod encryption_method; 70 EncryptionMethod encryption_method;
66 BackoffOverride backoff_override; 71 BackoffOverride backoff_override;
72 NudgeDelay nudge_delay;
67 PreCommitUpdatesPolicy pre_commit_updates_policy; 73 PreCommitUpdatesPolicy pre_commit_updates_policy;
68 }; 74 };
69 75
70 // For selecting the types of storage to use to persist sync data when 76 // For selecting the types of storage to use to persist sync data when
71 // BuildDirectoryBackingStore() is called. 77 // BuildDirectoryBackingStore() is called.
72 enum StorageOption { 78 enum StorageOption {
73 // BuildDirectoryBackingStore should not use persistent on-disk storage. 79 // BuildDirectoryBackingStore should not use persistent on-disk storage.
74 STORAGE_IN_MEMORY, 80 STORAGE_IN_MEMORY,
75 // Use this if you want BuildDirectoryBackingStore to create/use a real 81 // Use this if you want BuildDirectoryBackingStore to create/use a real
76 // on disk store. 82 // on disk store.
(...skipping 24 matching lines...) Expand all
101 const base::FilePath& backing_filepath) = 0; 107 const base::FilePath& backing_filepath) = 0;
102 108
103 // Returns the Switches struct that this object is using as configuration, if 109 // Returns the Switches struct that this object is using as configuration, if
104 // the implementation is making use of one. 110 // the implementation is making use of one.
105 virtual Switches GetSwitches() const = 0; 111 virtual Switches GetSwitches() const = 0;
106 }; 112 };
107 113
108 } // namespace syncer 114 } // namespace syncer
109 115
110 #endif // COMPONENTS_SYNC_ENGINE_ENGINE_COMPONENTS_FACTORY_H_ 116 #endif // COMPONENTS_SYNC_ENGINE_ENGINE_COMPONENTS_FACTORY_H_
OLDNEW
« no previous file with comments | « components/sync/driver/sync_driver_switches.cc ('k') | components/sync/engine/engine_components_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698