Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/sync/test/integration/bookmarks_helper.h

Issue 2479313004: [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 // Checker used to block until bookmarks match on all clients. 220 // Checker used to block until bookmarks match on all clients.
221 class BookmarksMatchChecker : public MultiClientStatusChangeChecker { 221 class BookmarksMatchChecker : public MultiClientStatusChangeChecker {
222 public: 222 public:
223 BookmarksMatchChecker(); 223 BookmarksMatchChecker();
224 224
225 // StatusChangeChecker implementation. 225 // StatusChangeChecker implementation.
226 bool IsExitConditionSatisfied() override; 226 bool IsExitConditionSatisfied() override;
227 std::string GetDebugMessage() const override; 227 std::string GetDebugMessage() const override;
228 }; 228 };
229 229
230 // Checker used to block until bookmarks match the verifier bookmark model.
231 class BookmarksMatchVerifierChecker : public MultiClientStatusChangeChecker {
232 public:
233 BookmarksMatchVerifierChecker();
234
235 // StatusChangeChecker implementation.
236 bool IsExitConditionSatisfied() override;
237 std::string GetDebugMessage() const override;
238 };
239
230 // Checker used to block until the actual number of bookmarks with the given 240 // Checker used to block until the actual number of bookmarks with the given
231 // title match the expected count. 241 // title match the expected count.
232 // TODO(pvalenzuela): Remove this class and instead use 242 // TODO(pvalenzuela): Remove this class and instead use
233 // AwaitMatchStatusChangeChecker. 243 // AwaitMatchStatusChangeChecker.
234 class BookmarksTitleChecker : public SingleClientStatusChangeChecker { 244 class BookmarksTitleChecker : public SingleClientStatusChangeChecker {
235 public: 245 public:
236 BookmarksTitleChecker(int profile_index, 246 BookmarksTitleChecker(int profile_index,
237 const std::string& title, 247 const std::string& title,
238 int expected_count); 248 int expected_count);
239 249
240 // StatusChangeChecker implementation. 250 // StatusChangeChecker implementation.
241 bool IsExitConditionSatisfied() override; 251 bool IsExitConditionSatisfied() override;
242 std::string GetDebugMessage() const override; 252 std::string GetDebugMessage() const override;
243 253
244 private: 254 private:
245 const int profile_index_; 255 const int profile_index_;
246 const std::string title_; 256 const std::string title_;
247 const int expected_count_; 257 const int expected_count_;
248 }; 258 };
249 259
250 // Checker used to block until the actual number of bookmarks with the given url 260 // Checker used to block until the actual number of bookmarks with the given url
251 // match the expected count. 261 // match the expected count.
252 class BookmarksUrlChecker : public AwaitMatchStatusChangeChecker { 262 class BookmarksUrlChecker : public AwaitMatchStatusChangeChecker {
253 public: 263 public:
254 BookmarksUrlChecker(int profile, const GURL& url, int expected_count); 264 BookmarksUrlChecker(int profile, const GURL& url, int expected_count);
255 }; 265 };
256 266
257 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_ 267 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698