[sync] "TwoClientBookmarksSyncTest.Sanity" is flaky

components/sync/driver/sync_driver_switches.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/driver/sync_driver_switches.h"
 
 namespace switches {
 
 // Allows overriding the deferred init fallback timeout.
 const char kSyncDeferredStartupTimeoutSeconds[] =
     "sync-deferred-startup-timeout-seconds";
 
 // Enables deferring sync backend initialization until user initiated changes
 // occur.
 const char kSyncDisableDeferredStartup[] = "sync-disable-deferred-startup";
 
 // Enables feature to avoid unnecessary GetUpdate requests.
 const char kSyncEnableGetUpdateAvoidance[] = "sync-enable-get-update-avoidance";
 
 // Overrides the default server used for profile sync.
 const char kSyncServiceURL[] = "sync-url";
 
 // This flag causes sync to retry very quickly (see polling_constants.h) the
 // when it encounters an error, as the first step towards exponential backoff.
 const char kSyncShortInitialRetryOverride[] =
     "sync-short-initial-retry-override";
 
+// This flag significantly shortens the delay between nudge cycles. Its primary
+// purpose is to speed up integration tests.The normal delay allows coalescing

[Nicolas Zea, 2016/11/09 00:35:13]

nit: "test.The" -> "test. The"

[Patrick Noland, 2016/11/10 22:13:00]

Done.

+// and prevention of server load, so don't use this unless you're really sure

[Nicolas Zea, 2016/11/09 00:35:13]

nit: "server load" -> "server overload"

[Patrick Noland, 2016/11/10 22:13:00]

Done.

+// that it's what you want.
+const char kSyncShortNudgeDelay[] = "sync-short-nudge-delay";

[Nicolas Zea, 2016/11/09 00:35:13]

I think it might be good to call this short-nudge-delay-for-test, or something
like that to make it clear it's for tests only.

[Patrick Noland, 2016/11/10 22:13:00]

Done.

+
 // Enables clearing of sync data when a user enables passphrase encryption.
 const base::Feature kSyncClearDataOnPassphraseEncryption{
     "ClearSyncDataOnPassphraseEncryption", base::FEATURE_DISABLED_BY_DEFAULT};
 
 // Enables USS implementation of DeviceInfo datatype. This flag controls whether
-// SyncableService based or ModelTypeSyncBridge based implementation is used for
+// SyncableService based or ModelTypeService based implementation is used for
 // DeviceInfo type.
 const base::Feature kSyncUSSDeviceInfo{"EnableSyncUSSDeviceInfo",
                                        base::FEATURE_DISABLED_BY_DEFAULT};
 
 }  // namespace switches