core/fpdfapi/parser/cpdf_document.cpp - Issue 2479303002: Use unique_ptr return from CPDF_Parser::ParseIndirectObject()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_document.cpp

Issue 2479303002: Use unique_ptr return from CPDF_Parser::ParseIndirectObject() (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_document.cpp

diff --git a/core/fpdfapi/parser/cpdf_document.cpp b/core/fpdfapi/parser/cpdf_document.cpp

index 8e181de97cf54a94010c3ff88c9e0b360cf80fa7..7cf08aeac73da1a5232d81da368f85e246c3f846 100644

--- a/core/fpdfapi/parser/cpdf_document.cpp

+++ b/core/fpdfapi/parser/cpdf_document.cpp

@@ -353,7 +353,8 @@ CPDF_Document::~CPDF_Document() {

m_pByteStringPool.DeleteObject(); // Make weak.

}

-CPDF_Object* CPDF_Document::ParseIndirectObject(uint32_t objnum) {

+std::unique_ptr<CPDF_Object> CPDF_Document::ParseIndirectObject(

+ uint32_t objnum) {

return m_pParser ? m_pParser->ParseIndirectObject(this, objnum) : nullptr;

}