Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2479293004: Add an error when a type parameter from a generic function is used in an is test (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an error when a type parameter from a generic function is used in an is test R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6ce2f220e3c755e708db02d6acc5584bf9d5aa79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -2 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +25 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 1 month ago (2016-11-08 22:34:22 UTC) #2
scheglov
LGTM
4 years, 1 month ago (2016-11-08 22:38:34 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-09 15:47:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ce2f220e3c755e708db02d6acc5584bf9d5aa79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698