Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2479293003: Revert "Fix flakiness in page_load_metrics_browser_test" (Closed)

Created:
4 years, 1 month ago by droger
Modified:
4 years, 1 month ago
Reviewers:
pasko, Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix flakiness in page_load_metrics_browser_test" This reverts commit 2ce641d6fa80fc0a9ea2fe1484f6040224e2a6a3. The fix seems to have failed, because the tests are still flaky. Remove the code, as the additional complexity is not worth it. BUG=657022 Committed: https://crrev.com/da3cfdb3e1f0b69e10aaadc30ff05811c26f46af Cr-Commit-Position: refs/heads/master@{#431886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -97 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 17 chunks +0 lines, -97 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
droger
4 years, 1 month ago (2016-11-08 12:45:02 UTC) #7
pasko
lgtm from prefetch POV. Not sure about the metrics in general, could be still beneficial ...
4 years, 1 month ago (2016-11-08 14:15:18 UTC) #8
droger
bmcquade: ping
4 years, 1 month ago (2016-11-14 09:38:07 UTC) #9
Bryan McQuade
lgtm
4 years, 1 month ago (2016-11-14 14:33:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479293003/1
4 years, 1 month ago (2016-11-14 14:46:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 19:09:43 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 19:34:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da3cfdb3e1f0b69e10aaadc30ff05811c26f46af
Cr-Commit-Position: refs/heads/master@{#431886}

Powered by Google App Engine
This is Rietveld 408576698