Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2479253002: Revert of Replace flaky smoke test (Closed)

Created:
4 years, 1 month ago by msarett
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, msarett1
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace flaky smoke test (patchset #1 id:1 of https://codereview.chromium.org/2477013003/ ) Reason for revert: Still breaking the Android bot Original issue's description: > Replace flaky PNG smoke test > > The removed test is a bit slow, which I suspect is > causing flaky behavior on Android. The test that > is replacing it provides coverage of png decoding > and color correction. > > BUG=657839 > BUG=661769 > > Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 > Cr-Commit-Position: refs/heads/master@{#430270} TBR=dpranke@chromium.org,msarett@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657839 Committed: https://crrev.com/375372bceae5a843cf14bd02ae5354c3ed2019ab Cr-Commit-Position: refs/heads/master@{#430291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/SmokeTests View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
msarett
Created Revert of Replace flaky smoke test
4 years, 1 month ago (2016-11-07 16:12:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479253002/1
4 years, 1 month ago (2016-11-07 16:12:57 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-07 16:12:58 UTC) #5
msarett1
lgtm
4 years, 1 month ago (2016-11-07 16:31:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479253002/1
4 years, 1 month ago (2016-11-07 16:32:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 16:33:08 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 16:42:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/375372bceae5a843cf14bd02ae5354c3ed2019ab
Cr-Commit-Position: refs/heads/master@{#430291}

Powered by Google App Engine
This is Rietveld 408576698