Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3559)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.h

Issue 2479143003: Add tests for the XPC client. (Closed)
Patch Set: rename alert_dispatcher.h to alert_dispatcher_mac.h and add it to the BUILD.gn file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_mac.h
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.h b/chrome/browser/notifications/notification_platform_bridge_mac.h
index 7b8a892abbffba92841496f0d81d5afbe8d725e8..e573e6bbadc7808ba68058c15b25e84def85b6ce 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.h
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.h
@@ -11,12 +11,12 @@
#include "base/compiler_specific.h"
#include "base/mac/scoped_nsobject.h"
#include "base/macros.h"
+#include "chrome/browser/notifications/alert_dispatcher_mac.h"
#include "chrome/browser/notifications/notification_common.h"
#include "chrome/browser/notifications/notification_platform_bridge.h"
class Notification;
@class NotificationCenterDelegate;
-@class NotificationRemoteDispatcher;
@class NSDictionary;
@class NSUserNotificationCenter;
@class NSXPCConnection;
@@ -26,8 +26,9 @@ class PrefService;
// send platform notifications to the the MacOSX notification center.
class NotificationPlatformBridgeMac : public NotificationPlatformBridge {
public:
- explicit NotificationPlatformBridgeMac(
- NSUserNotificationCenter* notification_center);
+ NotificationPlatformBridgeMac(NSUserNotificationCenter* notification_center,
+ id<AlertDispatcher> alert_dispatcher);
+
~NotificationPlatformBridgeMac() override;
// NotificationPlatformBridge implementation.
@@ -36,6 +37,7 @@ class NotificationPlatformBridgeMac : public NotificationPlatformBridge {
const std::string& profile_id,
bool incognito,
const Notification& notification) override;
+
void Close(const std::string& profile_id,
const std::string& notification_id) override;
bool GetDisplayed(const std::string& profile_id,
@@ -56,11 +58,10 @@ class NotificationPlatformBridgeMac : public NotificationPlatformBridge {
// The notification center to use for local banner notifications,
// this can be overriden in tests.
- NSUserNotificationCenter* notification_center_;
+ base::scoped_nsobject<NSUserNotificationCenter> notification_center_;
// The object in charge of dispatching remote notifications.
- base::scoped_nsobject<NotificationRemoteDispatcher>
- notification_remote_dispatcher_;
+ base::scoped_nsprotocol<id<AlertDispatcher>> alert_dispatcher_;
DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac);
};
« no previous file with comments | « chrome/browser/notifications/alert_dispatcher_mac.h ('k') | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698