Add tests for the XPC client.

chrome/browser/notifications/notification_platform_bridge_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
 
 #include <set>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
+#include "chrome/browser/notifications/alert_dispatcher.h"
 #include "chrome/browser/notifications/notification_common.h"
 #include "chrome/browser/notifications/notification_platform_bridge.h"
 
 class Notification;
 @class NotificationCenterDelegate;
-@class NotificationRemoteDispatcher;
 @class NSDictionary;
 @class NSUserNotificationCenter;
 @class NSXPCConnection;
 class PrefService;
 
 // This class is an implementation of NotificationPlatformBridge that will
 // send platform notifications to the the MacOSX notification center.
 class NotificationPlatformBridgeMac : public NotificationPlatformBridge {
  public:
-  explicit NotificationPlatformBridgeMac(
-      NSUserNotificationCenter* notification_center);
+  NotificationPlatformBridgeMac(NSUserNotificationCenter* notification_center,
+                                id<AlertDispatcher> alert_dispatcher);

[Robert Sesek, 2016/11/07 17:51:18]

What's the ownership of the alert_dispatcher here? Comment for weak or use a
scoper and std::move.

[Miguel Garcia, 2016/11/10 12:46:52]

So it is owned by the NotificationPlatformBridgeMac object so I guess it's
strong then? Weak would be if it wasn't owned by the class where it is injected
right?

[Robert Sesek, 2016/11/10 23:52:41]

Right.

[Miguel Garcia, 2016/11/11 15:26:40]

Done.

+
   ~NotificationPlatformBridgeMac() override;
 
   // NotificationPlatformBridge implementation.
   void Display(NotificationCommon::Type notification_type,
                const std::string& notification_id,
                const std::string& profile_id,
                bool incognito,
                const Notification& notification) override;
+
   void Close(const std::string& profile_id,
              const std::string& notification_id) override;
   bool GetDisplayed(const std::string& profile_id,
                     bool incognito,
                     std::set<std::string>* notifications) const override;
 
   // Processes a notification response generated from a user action
   // (click close, etc.).
   static void ProcessNotificationResponse(NSDictionary* response);
 
   // Validates contents of the |response| dictionary as received from the system
   // when a notification gets activated.
   static bool VerifyNotificationData(NSDictionary* response) WARN_UNUSED_RESULT;
 
  private:
   // Cocoa class that receives callbacks from the NSUserNotificationCenter.
   base::scoped_nsobject<NotificationCenterDelegate> delegate_;
 
   // The notification center to use for local banner notifications,
   // this can be overriden in tests.
   NSUserNotificationCenter* notification_center_;
 
   // The object in charge of dispatching remote notifications.
-  base::scoped_nsobject<NotificationRemoteDispatcher>
-      notification_remote_dispatcher_;
+  // id<AlertDispatcher>
+  base::scoped_nsobject<id> alert_dispatcher_;

[Miguel Garcia, 2016/11/07 14:24:14]

I have not found a better way to define that the what's inside the ns object
should be a protocol of type AlertDispatcher.

[Robert Sesek, 2016/11/07 17:51:18]

scoped_nsprotocol<id<AlertDispatcher>> ?

[Miguel Garcia, 2016/11/10 12:46:52]

That seems to expect an object of type id<AlertDispatcher>* 
I code searched a bit and the very few instances in chrome seem to go with what
I have
https://cs.chromium.org/search/?q=%22scoped_nsobject%3Cid%22+file:chrome/+-fi...

[Robert Sesek, 2016/11/10 23:52:41]

Did you try my suggestion? It should work:

https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/constrained_wind...

[Miguel Garcia, 2016/11/11 15:26:40]

I had misread your suggestion (scoped_nsobject vs scoped_nsprotocol) apologies
for the confusion. Done now.

On 2016/11/10 23:52:41, Robert Sesek wrote:

 
   DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_