third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl - Issue 2479133002: [wrapper-tracing] Fix dispatching of TraceWrapperv8Reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2479133002: [wrapper-tracing] Fix dispatching of TraceWrapperv8Reference (Closed)

Patch Set: Regenerate bindings results Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_callback_function.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

index 8fe5cfcdf5a0317e461eee17483d05b2f8ad723e..87581e649f0ef8b8350ce3497b0d2d0be2a4f0a6 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

@@ -15,7 +15,6 @@ namespace blink {

: m_scriptState(scriptState),

m_callback(scriptState->isolate(), this, callback) {

DCHECK(!m_callback.isEmpty());

- m_callback.setPhantom();

}

DEFINE_TRACE({{cpp_class}}) {}