third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 2479133002: [wrapper-tracing] Fix dispatching of TraceWrapperv8Reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 2479133002: [wrapper-tracing] Fix dispatching of TraceWrapperv8Reference (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h ('k') | third_party/WebKit/Source/bindings/scripts/v8_callback_function.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

index 46886c70f8619b437939a58f9c983401b3054c3c..1c45b808ff8706ac388b4962d4e1319e3da2b705 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -109,8 +109,8 @@ void V8AbstractEventListener::setListenerObject(

} else {

m_keepAlive = this;

}

- m_listener.set(isolate(), listener);

- m_listener.setWeak(this, &wrapperCleared);

+ m_listener.set(isolate(), listener, this, &wrapperCleared);

+ // m_listener.setWeak(this, &wrapperCleared);

haraken 2016/11/07 14:27:58 Remove this?

Michael Lippautz 2016/11/07 15:07:15 Done.

}

void V8AbstractEventListener::invokeEventHandler(ScriptState* scriptState,