third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp - Issue 2479133002: [wrapper-tracing] Fix dispatching of TraceWrapperv8Reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2479133002: [wrapper-tracing] Fix dispatching of TraceWrapperv8Reference (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('K') | « third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('k') | third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h » ('j') | third_party/WebKit/Source/bindings/core/v8/TraceWrapperV8Reference.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

index 1743e3cc2d251b3d72fc88d68a207936eb42e48a..87d977156751d3f4edeeadf7aa0a8acf9aea7979 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

@@ -5,6 +5,7 @@

#include "bindings/core/v8/ScriptWrappableVisitor.h"

#include "bindings/core/v8/ToV8.h"

+#include "bindings/core/v8/TraceWrapperV8Reference.h"

#include "bindings/core/v8/V8BindingForTesting.h"

#include "bindings/core/v8/V8GCController.h"

#include "bindings/core/v8/V8PerIsolateData.h"

@@ -299,7 +300,6 @@ class HandleContainer

void setValue(v8::Isolate* isolate, v8::Local<v8::String> string) {

m_handle.set(isolate, string);

- m_handle.setPhantom();

}

private: