Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 247913003: Rename benchmark classes, hopefully less confusing to valgrid? (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rename benchmark classes, hopefully less confusing to valgrid? I was able to reproduce the problem, but Valgrind was giving me a very odd report, pointing to a particular line in QuadTreeBench.cpp from a stack that was running RTreeBench. Whenever Valgrind complains, it's always about switch(fQuery), line 109 in QuadTreeBench or 119 in RTreeBench. I can't see any way that fQuery is not initialized. I believe we've just confused Valgrind by linking together classes with identical names. This CL gives them all unique names. BUG=skia:2455 Committed: http://code.google.com/p/skia/source/detail?r=14338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -67 lines) Patch
M bench/QuadTreeBench.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M bench/RTreeBench.cpp View 6 chunks +33 lines, -33 lines 0 comments Download
M bench/valgrind.supp View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 8 months ago (2014-04-22 21:08:51 UTC) #1
mtklein
First review's a winner!
6 years, 8 months ago (2014-04-23 20:02:35 UTC) #2
bungeman-skia
lgtm
6 years, 8 months ago (2014-04-23 20:04:08 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-23 20:04:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/247913003/1
6 years, 8 months ago (2014-04-23 20:04:30 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 21:03:47 UTC) #6
Message was sent while issue was closed.
Change committed as 14338

Powered by Google App Engine
This is Rietveld 408576698