content/common/DEPS - Issue 2479123003: WIP Add getCoalescedEvents API using vector of WebInputEvents

Side by Side Diff: content/common/DEPS

Issue 2479123003: WIP Add getCoalescedEvents API using vector of WebInputEvents (Closed)

Patch Set: Creating CoalescedWebInputEvent Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl.cc ('k') | content/common/input/event_with_latency_info.h » ('j') | third_party/WebKit/Source/web/CoalescedWebInputEvent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-storage/browser",	2 "-storage/browser",

3	3

4 "+components/discardable_memory/common",	4 "+components/discardable_memory/common",

5 "+device/base/synchronization",	5 "+device/base/synchronization",

6 "+services/service_manager/public/cpp",	6 "+services/service_manager/public/cpp",

7 "+services/video_capture/public/interfaces",	7 "+services/video_capture/public/interfaces",

8	8

9 # No inclusion of WebKit from the browser, other than strictly enum/POD,	9 # No inclusion of WebKit from the browser, other than strictly enum/POD,

10 # header-only types, and some selected common code.	10 # header-only types, and some selected common code.

11 "-third_party/WebKit",	11 "-third_party/WebKit",

	12 "+third_party/WebKit/public/platform/CoalescedWebInputEvent.h",
	Navid Zolghadr 2016/11/16 17:17:38 Dave, is this okay to include such a object like C Dave, is this okay to include such a object like CoalescedWebInputEvent here? It doesn't seem to be inline with the comment above. If not I won't be able to modify the ScopedWebInputEventWithLatencyInfo to contain a coalesced event and I should find another place to keep that structure. jbroman 2016/11/22 15:27:37 Is there a lot of value to doing this, as opposed Show quoted text On 2016/11/16 at 17:17:38, Navid Zolghadr wrote: > Dave, is this okay to include such a object like CoalescedWebInputEvent here? It doesn't seem to be inline with the comment above. If not I won't be able to modify the ScopedWebInputEventWithLatencyInfo to contain a coalesced event and I should find another place to keep that structure. Is there a lot of value to doing this, as opposed to just carrying around std::vector until we call into Blink? Yes it's another copy, but I think we'd rather move toward having _less_ Blink code running in the browser process, not more. (It's tricky, because using certain Blink classes requires Blink to be initialized, which it is not in the browser process.) Navid Zolghadr 2016/11/22 15:38:04 So you are suggesting something like what I had in Show quoted text On 2016/11/22 15:27:37, jbroman wrote: > On 2016/11/16 at 17:17:38, Navid Zolghadr wrote: > > Dave, is this okay to include such a object like CoalescedWebInputEvent here? > It doesn't seem to be inline with the comment above. If not I won't be able to > modify the ScopedWebInputEventWithLatencyInfo to contain a coalesced event and I > should find another place to keep that structure. > > Is there a lot of value to doing this, as opposed to just carrying around > std::vector until we call into Blink? Yes it's another copy, but I think we'd > rather move toward having _less_ Blink code running in the browser process, not > more. (It's tricky, because using certain Blink classes requires Blink to be > initialized, which it is not in the browser process.) So you are suggesting something like what I had in the patchset 1 right? jbroman 2016/11/22 16:02:39 Discussed offline. It'd be nice not to expand this Show quoted text On 2016/11/22 at 15:38:04, Navid Zolghadr wrote: > On 2016/11/22 15:27:37, jbroman wrote: > > On 2016/11/16 at 17:17:38, Navid Zolghadr wrote: > > > Dave, is this okay to include such a object like CoalescedWebInputEvent here? > > It doesn't seem to be inline with the comment above. If not I won't be able to > > modify the ScopedWebInputEventWithLatencyInfo to contain a coalesced event and I > > should find another place to keep that structure. > > > > Is there a lot of value to doing this, as opposed to just carrying around > > std::vector until we call into Blink? Yes it's another copy, but I think we'd > > rather move toward having _less_ Blink code running in the browser process, not > > more. (It's tricky, because using certain Blink classes requires Blink to be > > initialized, which it is not in the browser process.) > > So you are suggesting something like what I had in the patchset 1 right? Discussed offline. It'd be nice not to expand this list at all, but something that was at least all in the header (and doesn't require linking any non-inline Blink code) would probably be okay. Do check with esprehn@ and content/OWNERS, though, because this is likely to be controversial. Navid Zolghadr 2016/11/22 16:59:54 esprehn@, jochen@ what do you think about this? We Show quoted text On 2016/11/22 16:02:39, jbroman wrote: > On 2016/11/22 at 15:38:04, Navid Zolghadr wrote: > > On 2016/11/22 15:27:37, jbroman wrote: > > > On 2016/11/16 at 17:17:38, Navid Zolghadr wrote: > > > > Dave, is this okay to include such a object like CoalescedWebInputEvent > here? > > > It doesn't seem to be inline with the comment above. If not I won't be able > to > > > modify the ScopedWebInputEventWithLatencyInfo to contain a coalesced event > and I > > > should find another place to keep that structure. > > > > > > Is there a lot of value to doing this, as opposed to just carrying around > > > std::vector until we call into Blink? Yes it's another copy, but I think > we'd > > > rather move toward having _less_ Blink code running in the browser process, > not > > > more. (It's tricky, because using certain Blink classes requires Blink to be > > > initialized, which it is not in the browser process.) > > > > So you are suggesting something like what I had in the patchset 1 right? > > Discussed offline. It'd be nice not to expand this list at all, but something > that was at least all in the header (and doesn't require linking any non-inline > Blink code) would probably be okay. Do check with esprehn@ and content/OWNERS, > though, because this is likely to be controversial. esprehn@, jochen@ what do you think about this? We need a class here (in this patched it is called CoalescedWebInputEvent which represents both the WebInputEvent and all its coalesced events. Not that the WebInputEvent is a polymorphic class and we seem to have a custom logic for deletion instead of using virtual destructors. Here is some context in the design doc: https://docs.google.com/a/chromium.org/document/d/1x-e8fH3I0DBrmrNufPQwRJHMYn... So is it okay to have the code outside of Blink to depend on such a class? If no what if we move the code in the CoalescedWebInputEvent.cpp file (which is mainly a container logic) to the CoalescedWebInputEvent.h?
12 "+third_party/WebKit/public/platform/WebAddressSpace.h",	13 "+third_party/WebKit/public/platform/WebAddressSpace.h",

13 "+third_party/WebKit/public/platform/WebCString.h",	14 "+third_party/WebKit/public/platform/WebCString.h",

14 "+third_party/WebKit/public/platform/WebDisplayMode.h",	15 "+third_party/WebKit/public/platform/WebDisplayMode.h",

15 "+third_party/WebKit/public/platform/WebDragOperation.h",	16 "+third_party/WebKit/public/platform/WebDragOperation.h",

16 "+third_party/WebKit/public/platform/WebFloatPoint.h",	17 "+third_party/WebKit/public/platform/WebFloatPoint.h",

17 "+third_party/WebKit/public/platform/WebFloatRect.h",	18 "+third_party/WebKit/public/platform/WebFloatRect.h",

18 "+third_party/WebKit/public/platform/WebFocusType.h",	19 "+third_party/WebKit/public/platform/WebFocusType.h",

19 "+third_party/WebKit/public/platform/WebGamepad.h",	20 "+third_party/WebKit/public/platform/WebGamepad.h",

20 "+third_party/WebKit/public/platform/WebGamepads.h",	21 "+third_party/WebKit/public/platform/WebGamepads.h",

21 "+third_party/WebKit/public/platform/WebGestureEvent.h",	22 "+third_party/WebKit/public/platform/WebGestureEvent.h",

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 "+third_party/WebKit/public/web/WebPopupType.h",	66 "+third_party/WebKit/public/web/WebPopupType.h",

66 "+third_party/WebKit/public/web/WebSandboxFlags.h",	67 "+third_party/WebKit/public/web/WebSandboxFlags.h",

67 "+third_party/WebKit/public/web/WebSharedWorkerCreationContextType.h",	68 "+third_party/WebKit/public/web/WebSharedWorkerCreationContextType.h",

68 "+third_party/WebKit/public/web/WebSharedWorkerCreationErrors.h",	69 "+third_party/WebKit/public/web/WebSharedWorkerCreationErrors.h",

69 "+third_party/WebKit/public/web/WebTextDirection.h",	70 "+third_party/WebKit/public/web/WebTextDirection.h",

70 "+third_party/WebKit/public/web/WebTreeScopeType.h",	71 "+third_party/WebKit/public/web/WebTreeScopeType.h",

71 "+third_party/WebKit/public/web/WebWindowFeatures.h",	72 "+third_party/WebKit/public/web/WebWindowFeatures.h",

72 "+third_party/WebKit/public/web/mac/WebScrollbarTheme.h",	73 "+third_party/WebKit/public/web/mac/WebScrollbarTheme.h",

73 "+third_party/WebKit/public/web/win/WebFontRendering.h"	74 "+third_party/WebKit/public/web/win/WebFontRendering.h"

74 ]	75 ]

OLD	NEW