Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4294)

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)
Patch Set: Added DSE tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h
diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h
index 5167a049a47666461a082edef9562bd4cbf4228d..92bdbea882ca317f12a9493a3d0a0cfe2d218942 100644
--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h
+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_API_H_
#define CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_API_H_
+#include <memory>
#include <set>
#include <string>
@@ -38,9 +39,9 @@ class SettingsOverridesAPI : public BrowserContextKeyedAPI,
// Wrappers around PreferenceAPI.
void SetPref(const std::string& extension_id,
const std::string& pref_key,
- base::Value* value);
+ std::unique_ptr<base::Value> value) const;
void UnsetPref(const std::string& extension_id,
- const std::string& pref_key);
+ const std::string& pref_key) const;
// ExtensionRegistryObserver implementation.
void OnExtensionLoaded(content::BrowserContext* browser_context,

Powered by Google App Engine
This is Rietveld 408576698