Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3361)

Unified Diff: components/search_engines/template_url_service.cc

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)
Patch Set: Move extension overriden DSE logic to setting_override_api.cc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_service.cc
diff --git a/components/search_engines/template_url_service.cc b/components/search_engines/template_url_service.cc
index 22e2db0b3fa16c320df785db633dc5f7ab4c8bfa..b3c025f0369f75707eee8bd3c87405a17b83b374 100644
--- a/components/search_engines/template_url_service.cc
+++ b/components/search_engines/template_url_service.cc
@@ -486,9 +486,6 @@ TemplateURL* TemplateURLService::AddExtensionControlledTURL(
KeywordWebDataService::BatchModeScoper scoper(web_data_service_.get());
TemplateURL* template_url_ptr = AddNoNotify(std::move(template_url), true);
if (template_url_ptr) {
- if (template_url_ptr->extension_info_->wants_to_be_default_engine) {
- UpdateExtensionDefaultSearchEngine();
- }
NotifyObservers();
}
@@ -508,12 +505,10 @@ void TemplateURLService::RemoveExtensionControlledTURL(
if (!url)
return;
// NULL this out so that we can call RemoveNoNotify.
- // UpdateExtensionDefaultSearchEngine will cause it to be reset.
if (default_search_provider_ == url)
default_search_provider_ = nullptr;
KeywordWebDataService::BatchModeScoper scoper(web_data_service_.get());
RemoveNoNotify(url);
- UpdateExtensionDefaultSearchEngine();
NotifyObservers();
}
@@ -2458,25 +2453,3 @@ TemplateURL* TemplateURLService::FindMatchingExtensionTemplateURL(
}
return nullptr;
}
-
-void TemplateURLService::UpdateExtensionDefaultSearchEngine() {
- TemplateURL* most_recently_intalled_default = nullptr;
- for (const auto& turl : template_urls_) {
- if ((turl->type() == TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION) &&
- turl->extension_info_->wants_to_be_default_engine &&
- turl->SupportsReplacement(search_terms_data()) &&
- (!most_recently_intalled_default ||
- (most_recently_intalled_default->extension_info_->install_time <
- turl->extension_info_->install_time)))
- most_recently_intalled_default = turl.get();
- }
-
- if (most_recently_intalled_default) {
- base::AutoReset<DefaultSearchChangeOrigin> change_origin(
- &dsp_change_origin_, DSP_CHANGE_OVERRIDE_SETTINGS_EXTENSION);
- default_search_manager_.SetExtensionControlledDefaultSearchEngine(
- most_recently_intalled_default->data());
- } else {
- default_search_manager_.ClearExtensionControlledDefaultSearchEngine();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698