chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h - Issue 2479113002: Make extensions DSE persistent in browser prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)

Patch Set: Move extension overriden DSE logic to setting_override_api.cc Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc » ('j') | components/search_engines/default_search_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

index 5167a049a47666461a082edef9562bd4cbf4228d..e8da3ef2096996c6e03e9ba1f34d89f38fe8376b 100644

--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

@@ -38,9 +38,9 @@ class SettingsOverridesAPI : public BrowserContextKeyedAPI,

// Wrappers around PreferenceAPI.

void SetPref(const std::string& extension_id,

const std::string& pref_key,

- base::Value* value);

+ base::Value* value) const;

vasilii 2016/11/09 14:29:56 It would be nice to accept a unique_ptr here.

Alexander Yashkin 2016/11/28 19:16:17 Done

void UnsetPref(const std::string& extension_id,

- const std::string& pref_key);

+ const std::string& pref_key) const;

// ExtensionRegistryObserver implementation.

void OnExtensionLoaded(content::BrowserContext* browser_context,