Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: components/search_engines/template_url.h

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)
Patch Set: Fixed after review, round 7 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url.h
diff --git a/components/search_engines/template_url.h b/components/search_engines/template_url.h
index af5f71f24db4953e6e74fe14b6ec34df0afe8c6b..9922a0e09c2d6ef40ee923289879241dac6ada60 100644
--- a/components/search_engines/template_url.h
+++ b/components/search_engines/template_url.h
@@ -512,10 +512,6 @@ class TemplateURL {
// Whether the search engine is supposed to be default.
bool wants_to_be_default_engine;
-
- // Used to resolve conflicts when there are multiple extensions specifying
- // the default search engine. The most recently-installed wins.
- base::Time install_time;
};
explicit TemplateURL(const TemplateURLData& data, Type type = NORMAL);
@@ -535,6 +531,12 @@ class TemplateURL {
const TemplateURLData* data,
const SearchTermsData& search_terms_data);
+ // Special case for search_terms_replacement_key comparison, because of
+ // its special initialization in TemplateUrl constructor.
Peter Kasting 2017/01/06 01:44:58 Nit: TemplateUrl -> TemplateURL
Alexander Yashkin 2017/01/07 12:56:00 Done.
+ static bool SearchTermsReplacementKeysMatch(
+ const std::string& search_terms_replacement_key1,
+ const std::string& search_terms_replacement_key2);
+
const TemplateURLData& data() const { return data_; }
const base::string16& short_name() const { return data_.short_name(); }
@@ -617,6 +619,10 @@ class TemplateURL {
extension_info_ = std::move(extension_info);
}
+ const AssociatedExtensionInfo* GetExtensionInfoForTesting() {
Peter Kasting 2017/01/06 01:44:58 Nit: Can be const
Alexander Yashkin 2017/01/07 12:56:00 Done.
+ return extension_info_.get();
+ }
+
// Returns true if |url| supports replacement.
bool SupportsReplacement(const SearchTermsData& search_terms_data) const;

Powered by Google App Engine
This is Rietveld 408576698