chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc - Issue 2479113002: Make extensions DSE persistent in browser prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/search_engines/chrome_template_url_service_client.h » ('j') | chrome/browser/search_engines/chrome_template_url_service_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

index 8ffa9275392a3d64c520fc9e2819eb4a48b9dfe8..8c53ac2e6d597aaa68d78ee07e789454c6d67f4d 100644

--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

@@ -236,6 +236,11 @@ void SettingsOverridesAPI::OnExtensionUnloaded(

UnsetPref(extension->id(), prefs::kURLsToRestoreOnStartup);

}

if (settings->search_engine) {

+ if (settings->search_engine->is_default) {

+ // Current extension can be overriding DSE.

+ UnsetPref(extension->id(),

+ DefaultSearchManager::kDefaultSearchProviderDataPrefName);

+ }

DCHECK(url_service_);

if (url_service_->loaded()) {

url_service_->RemoveExtensionControlledTURL(