Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)
Patch Set: Move extension overriden DSE logic to setting_override_api.cc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_API_ H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_API_ H_
6 #define CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_API_ H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_API_ H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 20 matching lines...) Expand all
31 GetFactoryInstance(); 31 GetFactoryInstance();
32 32
33 private: 33 private:
34 friend class BrowserContextKeyedAPIFactory<SettingsOverridesAPI>; 34 friend class BrowserContextKeyedAPIFactory<SettingsOverridesAPI>;
35 35
36 typedef std::set<scoped_refptr<const Extension> > PendingExtensions; 36 typedef std::set<scoped_refptr<const Extension> > PendingExtensions;
37 37
38 // Wrappers around PreferenceAPI. 38 // Wrappers around PreferenceAPI.
39 void SetPref(const std::string& extension_id, 39 void SetPref(const std::string& extension_id,
40 const std::string& pref_key, 40 const std::string& pref_key,
41 base::Value* value); 41 base::Value* value) const;
vasilii 2016/11/09 14:29:56 It would be nice to accept a unique_ptr here.
Alexander Yashkin 2016/11/28 19:16:17 Done
42 void UnsetPref(const std::string& extension_id, 42 void UnsetPref(const std::string& extension_id,
43 const std::string& pref_key); 43 const std::string& pref_key) const;
44 44
45 // ExtensionRegistryObserver implementation. 45 // ExtensionRegistryObserver implementation.
46 void OnExtensionLoaded(content::BrowserContext* browser_context, 46 void OnExtensionLoaded(content::BrowserContext* browser_context,
47 const Extension* extension) override; 47 const Extension* extension) override;
48 void OnExtensionUnloaded(content::BrowserContext* browser_context, 48 void OnExtensionUnloaded(content::BrowserContext* browser_context,
49 const Extension* extension, 49 const Extension* extension,
50 UnloadedExtensionInfo::Reason reason) override; 50 UnloadedExtensionInfo::Reason reason) override;
51 51
52 // KeyedService implementation. 52 // KeyedService implementation.
53 void Shutdown() override; 53 void Shutdown() override;
(...skipping 20 matching lines...) Expand all
74 DISALLOW_COPY_AND_ASSIGN(SettingsOverridesAPI); 74 DISALLOW_COPY_AND_ASSIGN(SettingsOverridesAPI);
75 }; 75 };
76 76
77 template <> 77 template <>
78 void BrowserContextKeyedAPIFactory< 78 void BrowserContextKeyedAPIFactory<
79 SettingsOverridesAPI>::DeclareFactoryDependencies(); 79 SettingsOverridesAPI>::DeclareFactoryDependencies();
80 80
81 } // namespace extensions 81 } // namespace extensions
82 82
83 #endif // CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_A PI_H_ 83 #endif // CHROME_BROWSER_EXTENSIONS_API_SETTINGS_OVERRIDES_SETTINGS_OVERRIDES_A PI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698