components/search_engines/search_engines_test_util.h - Issue 2479113002: Make extensions DSE persistent in browser prefs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/search_engines/search_engines_test_util.h

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)

Patch Set: Updated after review, round 6 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/search_engines/default_search_manager_unittest.cc ('K') | « components/search_engines/default_search_manager_unittest.cc ('k') | components/search_engines/search_engines_test_util.cc » ('j') | components/search_engines/search_engines_test_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_SEARCH_ENGINES_SEARCH_ENGINES_TEST_UTIL_H_

	6 #define COMPONENTS_SEARCH_ENGINES_SEARCH_ENGINES_TEST_UTIL_H_

	7

	8 #include <string>

	9

	10 struct TemplateURLData;

	11

	12 // Generate TemplateUrlData structure useful for tests filled with values
	Peter Kasting 2016/12/22 20:49:04 Nit: Url -> URL Nit: Url -> URL Alexander Yashkin 2016/12/23 19:44:09 Done Show quoted text On 2016/12/22 at 20:49:04, Peter Kasting wrote: > Nit: Url -> URL Done
	13 // autogenerated from provider_name param.

	14 std::unique_ptr<TemplateURLData> GenerateDummyTemplateURLData(
	Peter Kasting 2016/12/22 20:49:04 I'm kinda surprised we don't have functions like t I'm kinda surprised we don't have functions like these two already somewhere. I'm also wondering if we could refactor more of our tests code (not in this CL!) to use these. Alexander Yashkin 2016/12/23 19:44:09 I think I saw several similar functions across cod Show quoted text On 2016/12/22 at 20:49:04, Peter Kasting wrote: > I'm kinda surprised we don't have functions like these two already somewhere. > > I'm also wondering if we could refactor more of our tests code (not in this CL!) to use these. I think I saw several similar functions across code, for example in template_url_service_unittest.cc. Refactor is possible.
	15 const std::string& provider_name);

	16

	17 // Checks that the two TemplateURLs are similar. Does not check the id, the

	18 // date_created or the last_modified time. Neither pointer should be nullptr.
	Peter Kasting 2016/12/22 20:49:04 Nit: In comments, just say "null". Nit: In comments, just say "null". Alexander Yashkin 2016/12/23 19:44:09 Done Show quoted text On 2016/12/22 at 20:49:04, Peter Kasting wrote: > Nit: In comments, just say "null". Done
	19 void ExpectSimilar(const TemplateURLData* expected,

	20 const TemplateURLData* actual);

	21

	22 #endif // COMPONENTS_SEARCH_ENGINES_SEARCH_ENGINES_TEST_UTIL_H_

OLD	NEW