Make extensions DSE persistent in browser prefs

components/search_engines/search_engines_test_util.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/search_engines/search_engines_test_util.h"
+
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "components/search_engines/template_url.h"
+#include "components/search_engines/template_url_data.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+std::unique_ptr<TemplateURLData> GenerateDummyTemplateURLData(
+    const std::string& provider_name) {
+  std::unique_ptr<TemplateURLData> data(new TemplateURLData());

[Peter Kasting, 2016/12/22 20:49:04]

Nit: Prefer MakeUnique() to bare new

[Alexander Yashkin, 2016/12/23 19:44:09]

Done

+  data->SetShortName(base::UTF8ToUTF16(provider_name + "name"));
+  data->SetKeyword(base::UTF8ToUTF16(provider_name + "key"));
+  data->SetURL(std::string("http://") + provider_name + "foo/{searchTerms}");
+  data->suggestions_url = std::string("http://") + provider_name + "sugg";
+  data->alternate_urls.push_back(std::string("http://") + provider_name +
+                                 "foo/alt");
+  data->favicon_url = GURL("http://icon1");
+  data->safe_for_autoreplace = true;
+  data->input_encodings = {"UTF-8", "UTF-16"};
+  data->date_created = base::Time();
+  data->last_modified = base::Time();
+  return data;
+}
+
+void ExpectSimilar(const TemplateURLData* expected,
+                   const TemplateURLData* actual) {
+  ASSERT_TRUE(expected != NULL);
+  ASSERT_TRUE(actual != NULL);

[Peter Kasting, 2016/12/22 20:49:04]

Nit: Use nullptr, or just write ASSERT_TRUE(expected) and similar

[Alexander Yashkin, 2016/12/23 19:44:09]

Done

+
+  EXPECT_EQ(expected->short_name(), actual->short_name());
+  EXPECT_EQ(expected->keyword(), actual->keyword());
+  EXPECT_EQ(expected->url(), actual->url());
+  EXPECT_EQ(expected->suggestions_url, actual->suggestions_url);
+  EXPECT_EQ(expected->instant_url, actual->instant_url);
+  EXPECT_EQ(expected->image_url, actual->image_url);
+  EXPECT_EQ(expected->new_tab_url, actual->new_tab_url);
+  EXPECT_EQ(expected->contextual_search_url, actual->contextual_search_url);
+
+  EXPECT_EQ(expected->search_url_post_params, actual->search_url_post_params);
+  EXPECT_EQ(expected->suggestions_url_post_params,
+            actual->suggestions_url_post_params);
+  EXPECT_EQ(expected->instant_url_post_params, actual->instant_url_post_params);
+  EXPECT_EQ(expected->image_url_post_params, actual->image_url_post_params);
+
+  EXPECT_EQ(expected->favicon_url, actual->favicon_url);
+  EXPECT_EQ(expected->safe_for_autoreplace, actual->safe_for_autoreplace);
+  EXPECT_EQ(expected->input_encodings, actual->input_encodings);
+  EXPECT_EQ(expected->alternate_urls, actual->alternate_urls);
+  EXPECT_TRUE(TemplateURL::SearchTermsReplacementKeysMatch(
+      expected->search_terms_replacement_key,
+      actual->search_terms_replacement_key));
+}