Make extensions DSE persistent in browser prefs

chrome/browser/search_engines/template_url_service_test_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_TEST_UTIL_H_
 #define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_TEST_UTIL_H_
 
 #include <memory>
 #include <string>
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
+#include "components/search_engines/template_url.h"
 #include "components/search_engines/template_url_data.h"
 #include "components/search_engines/template_url_service_observer.h"
 
 class GURL;
 class KeywordWebDataService;
 class TemplateURLService;
 class TestingProfile;
 class TestingSearchTermsData;
 
 // Sets the managed preferences for the default search provider.
@@ skipping 33 matching lines @@
   // Creates a new TemplateURLService.
   void ResetModel(bool verify_load);
 
   // Returns the search term from the last invocation of
   // TemplateURLService::SetKeywordSearchTermsForURL and clears the search term.
   base::string16 GetAndClearSearchTerm();
 
   // Sets the google base url.  |base_url| must be valid.
   void SetGoogleBaseURL(const GURL& base_url);
 
+  // Write default search engine into extension controlled preference in test

[Peter Kasting, 2016/12/22 20:49:03]

Nit: Function comments should be declarative ("writes") rather than imperative
("write"); see
http://google.github.io/styleguide/cppguide.html#Function_Comments .  (4 places)

[Alexander Yashkin, 2016/12/23 19:44:08]

Done

+  // profile.
+  void SetExtensionDefaultSearchInPrefs(const std::string& ext_id,

[Peter Kasting, 2016/12/22 20:49:03]

This first arg is not actually used in the implementation.  Remove unused
parameters.  (2 places)

[Alexander Yashkin, 2016/12/23 19:44:08]

This remains from previous approach, removed.

+                                        const TemplateURLData& ext_data);

[Peter Kasting, 2016/12/22 20:49:03]

Nit: Avoid abbreviations like "ext" (could read as "external" or something); see
http://google.github.io/styleguide/cppguide.html#General_Naming_Rules .  If it's
clear that this is the extension ID and data, just say |id| and |data|.  If not,
say |extension_id| or the like.  (Multiple places)

[Alexander Yashkin, 2016/12/23 19:44:08]

Done, replaced with "extension_" or removed.

+  // Remove extension controlled default search engine preference from test

[Peter Kasting, 2016/12/22 20:49:03]

Nit: I'd still put a blink line above this comment even though these two
functions are loosely-related; it's enough to order them next to each other.  (2
places)

[Alexander Yashkin, 2016/12/23 19:44:08]

Done

+  // profile.
+  void RemoveExtensionDefaultSearchFromPrefs(const std::string& ext_id);
+
+  // Add extension turl to model and override default search preference if
+  // extension wants to be default.
+  TemplateURL* AddExtensionControlledTURL(
+      std::unique_ptr<TemplateURL> ext_dse,
+      std::unique_ptr<TemplateURL::AssociatedExtensionInfo> ext_info);
+  // Remove extension turl from preferences and model.

[Peter Kasting, 2016/12/22 20:49:03]

Nit: Expand this (and comments like it) to cover the function contract and give
more detail where relevant.  For example:

Removes a TemplateURL controlled by |ext_id| from the model, and, if necessary,
from the extension-controlled default search preference.  This TemplateURL must
exist.

[Alexander Yashkin, 2016/12/23 19:44:08]

Done, thanks.

+  void RemoveExtensionControlledTURL(const std::string& ext_id);
+
   KeywordWebDataService* web_data_service() { return web_data_service_.get(); }
   TemplateURLService* model() { return model_.get(); }
   TestingProfile* profile() { return profile_.get(); }
 
  private:
   std::unique_ptr<TestingProfile> profile_;
   base::ScopedTempDir temp_dir_;
   int changed_count_;
   base::string16 search_term_;
   scoped_refptr<KeywordWebDataService> web_data_service_;
   TestingSearchTermsData* search_terms_data_;
   std::unique_ptr<TemplateURLService> model_;
 
   DISALLOW_COPY_AND_ASSIGN(TemplateURLServiceTestUtil);
 };
 
 #endif  // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_TEST_UTIL_H_