Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2479093002: Migrate more files to histogram_macros.h from histogram.h. (Closed)

Created:
4 years, 1 month ago by Alexei Svitkine (slow)
Modified:
4 years, 1 month ago
Reviewers:
brettw, Ilya Sherman
CC:
chromium-reviews, zea+watch_chromium.org, tzik, posciak+watch_chromium.org, johnme+watch_chromium.org, oka+watch_chromium.org, apacible+watch_chromium.org, fukino+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, grt+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, jasonroberts+watch_google.com, yamaguchi+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, sync-reviews_chromium.org, avayvod+watch_chromium.org, isheriff+watch_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate more files to histogram_macros.h from histogram.h. With this change, all files required to build chrome target on Mac have been migrated. This CL does not yet remove the include in base/metrics/histogram.h since files for other targets & platforms still need migration. BUG=416479 TBR=brettw@chromium.org Committed: https://crrev.com/f5d4ee561189157f04d8aed34787f4db01e7ccd1 Cr-Commit-Position: refs/heads/master@{#430331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -63 lines) Patch
M chrome/browser/extensions/pending_extension_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/features.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/scorer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/connector_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/job_status_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_use_measurement/content/data_use_measurement.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/renderer/distillability_agent.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/drive/drive_notification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/job_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_metrics/navigation_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/profile_metrics/counts.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/data_type_error_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/geolocation/geolocation_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/app_runtime/app_runtime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_auth_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative/rules_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_time_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_verify_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/manifest_fetch_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/script_injection.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/scripts_run_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/auth_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_registration_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_unregistration_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/instance_id_delete_token_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/instance_id_get_token_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/external_video_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/meta_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/blob_storage_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/quota/quota_temporary_storage_evictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/blink/web_gesture_curve_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Alexei Svitkine (slow)
4 years, 1 month ago (2016-11-07 07:44:20 UTC) #2
Ilya Sherman
LGTM, thanks.
4 years, 1 month ago (2016-11-07 18:43:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479093002/1
4 years, 1 month ago (2016-11-07 18:43:52 UTC) #9
Alexei Svitkine (slow)
+TBR=brettw for OWNERS (this is downstream change of base/metrics which I have LGTM for)
4 years, 1 month ago (2016-11-07 18:49:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479093002/1
4 years, 1 month ago (2016-11-07 18:49:52 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 18:57:36 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 18:59:23 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d4ee561189157f04d8aed34787f4db01e7ccd1
Cr-Commit-Position: refs/heads/master@{#430331}

Powered by Google App Engine
This is Rietveld 408576698