Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2479043003: [wasm] fix TestInterruptLoop for Big Endian platform (Closed)

Created:
4 years, 1 month ago by JaideepBajwa
Modified:
4 years, 1 month ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com, JoranSiu, john.yan, michael_dawson
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] fix TestInterruptLoop for Big Endian platform Using Read/WriteLittleEndianValue method to access native memory. This will perform byte reversal depending on the endianness of the patform. Testcase was added in CL: https://codereview.chromium.org/2405293002 R=ahaas@chromium.org, titzer@chromium.org BUG= LOG=N Committed: https://crrev.com/e1a57a03b23b3ded3d4dbacdfba53d8c23ace93d Cr-Commit-Position: refs/heads/master@{#40815}

Patch Set 1 #

Patch Set 2 : workaround to avoid using const_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M test/cctest/wasm/test-run-wasm-module.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
JaideepBajwa
PTAL
4 years, 1 month ago (2016-11-07 19:33:16 UTC) #1
titzer
lgtm
4 years, 1 month ago (2016-11-07 19:34:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479043003/1
4 years, 1 month ago (2016-11-07 19:36:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/11933) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 20:03:18 UTC) #6
JaideepBajwa
ptal, updated to avoid the usage of const_cast
4 years, 1 month ago (2016-11-07 21:50:42 UTC) #11
titzer
lgtm
4 years, 1 month ago (2016-11-07 22:20:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479043003/20001
4 years, 1 month ago (2016-11-07 23:23:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 23:25:32 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1a57a03b23b3ded3d4dbacdfba53d8c23ace93d
Cr-Commit-Position: refs/heads/master@{#40815}

Powered by Google App Engine
This is Rietveld 408576698