Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 247903004: Enable settings in a window by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/browser_navigator_browsertest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 443
444 const Experiment::Choice kEnableFileManagerNewGalleryChoices[] = { 444 const Experiment::Choice kEnableFileManagerNewGalleryChoices[] = {
445 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 445 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
446 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 446 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
447 chromeos::switches::kFileManagerEnableNewGallery, "true"}, 447 chromeos::switches::kFileManagerEnableNewGallery, "true"},
448 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 448 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
449 chromeos::switches::kFileManagerEnableNewGallery, "false"} 449 chromeos::switches::kFileManagerEnableNewGallery, "false"}
450 }; 450 };
451 #endif 451 #endif
452 452
453 const Experiment::Choice kEnableSettingsWindowChoices[] = {
454 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
455 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
456 ::switches::kEnableSettingsWindow, "" },
457 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
458 ::switches::kDisableSettingsWindow, "" },
459 };
460
453 // RECORDING USER METRICS FOR FLAGS: 461 // RECORDING USER METRICS FOR FLAGS:
454 // ----------------------------------------------------------------------------- 462 // -----------------------------------------------------------------------------
455 // The first line of the experiment is the internal name. If you'd like to 463 // The first line of the experiment is the internal name. If you'd like to
456 // gather statistics about the usage of your flag, you should append a marker 464 // gather statistics about the usage of your flag, you should append a marker
457 // comment to the end of the feature name, like so: 465 // comment to the end of the feature name, like so:
458 // "my-special-feature", // FLAGS:RECORD_UMA 466 // "my-special-feature", // FLAGS:RECORD_UMA
459 // 467 //
460 // After doing that, run 468 // After doing that, run
461 // tools/metrics/actions/extract_actions.py 469 // tools/metrics/actions/extract_actions.py
462 // to add the metric to actions.xml (which will enable UMA to record your 470 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 1303 matching lines...) Expand 10 before | Expand all | Expand 10 after
1766 IDS_FLAGS_BLEEDING_RENDERER_NAME, 1774 IDS_FLAGS_BLEEDING_RENDERER_NAME,
1767 IDS_FLAGS_BLEEDING_RENDERER_DESCRIPTION, 1775 IDS_FLAGS_BLEEDING_RENDERER_DESCRIPTION,
1768 kOsAndroid, 1776 kOsAndroid,
1769 SINGLE_VALUE_TYPE(switches::kEnableBleedingEdgeRenderingFastPaths) 1777 SINGLE_VALUE_TYPE(switches::kEnableBleedingEdgeRenderingFastPaths)
1770 }, 1778 },
1771 { 1779 {
1772 "enable-settings-window", 1780 "enable-settings-window",
1773 IDS_FLAGS_ENABLE_SETTINGS_WINDOW_NAME, 1781 IDS_FLAGS_ENABLE_SETTINGS_WINDOW_NAME,
1774 IDS_FLAGS_ENABLE_SETTINGS_WINDOW_DESCRIPTION, 1782 IDS_FLAGS_ENABLE_SETTINGS_WINDOW_DESCRIPTION,
1775 kOsDesktop, 1783 kOsDesktop,
1776 SINGLE_VALUE_TYPE(switches::kEnableSettingsWindow) 1784 MULTI_VALUE_TYPE(kEnableSettingsWindowChoices)
1777 }, 1785 },
1778 #if defined(OS_ANDROID) 1786 #if defined(OS_ANDROID)
1779 { 1787 {
1780 "enable-instant-search-clicks", 1788 "enable-instant-search-clicks",
1781 IDS_FLAGS_ENABLE_INSTANT_SEARCH_CLICKS_NAME, 1789 IDS_FLAGS_ENABLE_INSTANT_SEARCH_CLICKS_NAME,
1782 IDS_FLAGS_ENABLE_INSTANT_SEARCH_CLICKS_DESCRIPTION, 1790 IDS_FLAGS_ENABLE_INSTANT_SEARCH_CLICKS_DESCRIPTION,
1783 kOsAndroid, 1791 kOsAndroid,
1784 SINGLE_VALUE_TYPE(switches::kEnableInstantSearchClicks) 1792 SINGLE_VALUE_TYPE(switches::kEnableInstantSearchClicks)
1785 }, 1793 },
1786 #endif 1794 #endif
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
2451 } 2459 }
2452 2460
2453 const Experiment* GetExperiments(size_t* count) { 2461 const Experiment* GetExperiments(size_t* count) {
2454 *count = num_experiments; 2462 *count = num_experiments;
2455 return experiments; 2463 return experiments;
2456 } 2464 }
2457 2465
2458 } // namespace testing 2466 } // namespace testing
2459 2467
2460 } // namespace about_flags 2468 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser_navigator_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698