Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: content/renderer/input/input_event_filter.cc

Issue 2479023003: Remove is_fling flag for fling intervention (Closed)
Patch Set: Rename ack state Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_event_filter.cc
diff --git a/content/renderer/input/input_event_filter.cc b/content/renderer/input/input_event_filter.cc
index 56799b1128b224d40efe5c5edff70d23b09efa44..e40ae9091cfabc2e8dad3e9e0f02c3fdd971fc15 100644
--- a/content/renderer/input/input_event_filter.cc
+++ b/content/renderer/input/input_event_filter.cc
@@ -71,15 +71,6 @@ void InputEventFilter::SetInputHandlerManager(
input_handler_manager_ = input_handler_manager;
}
-void InputEventFilter::SetIsFlingingInMainThreadEventQueue(int routing_id,
- bool is_flinging) {
- RouteQueueMap::iterator iter = route_queues_.find(routing_id);
- if (iter == route_queues_.end() || !iter->second)
- return;
-
- iter->second->set_is_flinging(is_flinging);
-}
-
void InputEventFilter::RegisterRoutingID(int routing_id) {
base::AutoLock locked(routes_lock_);
routes_.insert(routing_id);
@@ -99,12 +90,7 @@ void InputEventFilter::DidOverscroll(int routing_id,
new InputHostMsg_DidOverscroll(routing_id, params)));
}
-void InputEventFilter::DidStartFlinging(int routing_id) {
- SetIsFlingingInMainThreadEventQueue(routing_id, true);
-}
-
void InputEventFilter::DidStopFlinging(int routing_id) {
- SetIsFlingingInMainThreadEventQueue(routing_id, false);
SendMessage(base::MakeUnique<InputHostMsg_DidStopFlinging>(routing_id));
}
@@ -251,7 +237,8 @@ void InputEventFilter::DidForwardToHandlerAndOverscroll(
WebInputEvent::Type type = event->type;
if (ack_state == INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING ||
- ack_state == INPUT_EVENT_ACK_STATE_NOT_CONSUMED) {
+ ack_state == INPUT_EVENT_ACK_STATE_NOT_CONSUMED ||
+ ack_state == INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING_DUE_TO_FLING) {
tdresser 2016/11/07 21:58:49 Nit: might be nice to reorder these such that the
lanwei 2016/11/07 23:25:18 Done.
DCHECK(!overscroll_params);
RouteQueueMap::iterator iter = route_queues_.find(routing_id);
if (iter != route_queues_.end()) {

Powered by Google App Engine
This is Rietveld 408576698