Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2478993002: [GeometryInterface] Remove Constructor(DOMMatrixReadOnly). (Closed)

Created:
4 years, 1 month ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] Remove Constructor(DOMMatrixReadOnly). it was removed in idl spec. speclist: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780, 660820 Committed: https://crrev.com/44aebaecbd7f679ab9b75edb89acc459ac9ed925 Cr-Commit-Position: refs/heads/master@{#432772}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
Hwanseung Lee
@dominicc, zino PTAL, Thank you.
4 years, 1 month ago (2016-11-12 08:42:43 UTC) #14
zino
lgtm
4 years, 1 month ago (2016-11-12 15:42:39 UTC) #15
Hwanseung Lee
@dominicc PTAL, thank you.
4 years, 1 month ago (2016-11-15 00:44:35 UTC) #16
dominicc (has gone to gerrit)
lgtm
4 years, 1 month ago (2016-11-17 03:10:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478993002/20001
4 years, 1 month ago (2016-11-17 03:16:23 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 05:49:07 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 05:53:10 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44aebaecbd7f679ab9b75edb89acc459ac9ed925
Cr-Commit-Position: refs/heads/master@{#432772}

Powered by Google App Engine
This is Rietveld 408576698