Issue 247893002: HPACK: Add HpackHuffmanTable::EncodedSize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247893002: HPACK: Add HpackHuffmanTable::EncodedSize() (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

HPACK: Add HpackHuffmanTable::EncodedSize() EncodedSize() will be used by the HPACK encoder to select identity vs Huffman coding, without having to run the full Huffman coder. Also update tests to compare against EncodedSize() by default. This lands server change 65187740 by jgraettinger. HPACK unittest: Fixing memory error in Huffman test fixture. This lands server change 65328503 by jgraettinger. BUG=339578

Patch Set 1 #

Patch Set 2 : Also include cr/65328503 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -80 lines)			Patch
M	net/spdy/hpack_huffman_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/spdy/hpack_huffman_table.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	net/spdy/hpack_huffman_table_test.cc	View	1	17 chunks	+116 lines, -80 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages