Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2478923003: DevTools: Distinguish between forced and unforced autocomplete in CMTE (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Distinguish between forced and unforced autocomplete in CMTE Ctrl+Space is now considered a "force" autocomplete. This is consistent with what we do in TextPrompt. BUG=659982 Committed: https://crrev.com/84eec56141ead73f870bc436fc4cf49037cb481c Cr-Commit-Position: refs/heads/master@{#430158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
einbinder
ptal
4 years, 1 month ago (2016-11-05 02:10:49 UTC) #4
lushnikov
lgtm shell we merge it?
4 years, 1 month ago (2016-11-05 03:02:24 UTC) #5
lushnikov
shall*. I meant "shall".
4 years, 1 month ago (2016-11-05 03:03:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478923003/1
4 years, 1 month ago (2016-11-05 07:51:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 07:58:52 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 08:02:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84eec56141ead73f870bc436fc4cf49037cb481c
Cr-Commit-Position: refs/heads/master@{#430158}

Powered by Google App Engine
This is Rietveld 408576698