Ensure that Chrome is visible in the dialog by default

chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h"
 #include "components/arc/intent_helper/arc_intent_helper_bridge.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
@@ skipping 130 matching lines @@
       1u, ArcNavigationThrottle::GetAppIndex(CreateArray(3, 1), package_name));
   EXPECT_EQ(
       2u, ArcNavigationThrottle::GetAppIndex(CreateArray(3, 2), package_name));
 }
 
 TEST(ArcNavigationThrottleTest, TestIsSwapElementsNeeded) {
   std::pair<size_t, size_t> indices;
   for (size_t i = 1; i <= ArcNavigationThrottle::kMaxAppResults; ++i) {
     // When Chrome is the first element, swap is unnecessary.
     mojo::Array<mojom::IntentHandlerInfoPtr> handlers = CreateArray(i, 0);
-    EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
-        handlers, &indices))
+    EXPECT_FALSE(
+        ArcNavigationThrottle::IsSwapElementsNeeded(handlers, &indices))
         << i;
 
     // When Chrome is within the first |kMaxAppResults| elements, swap is
     // unnecessary.
     handlers = CreateArray(i, i - 1);
-    EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
-        handlers, &indices))
+    EXPECT_FALSE(
+        ArcNavigationThrottle::IsSwapElementsNeeded(handlers, &indices))
         << i;
   }
 
   for (size_t i = ArcNavigationThrottle::kMaxAppResults + 1;
        i < ArcNavigationThrottle::kMaxAppResults * 2; ++i) {
     // When Chrome is within the first |kMaxAppResults| elements, swap is
     // unnecessary.
     mojo::Array<mojom::IntentHandlerInfoPtr> handlers = CreateArray(i, 0);
-    EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
-        handlers, &indices))
+    EXPECT_FALSE(
+        ArcNavigationThrottle::IsSwapElementsNeeded(handlers, &indices))
         << i;
 
     // When Chrome is the |kMaxAppResults|-th element, swap is unnecessary.
     handlers = CreateArray(i, ArcNavigationThrottle::kMaxAppResults - 1);
-    EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
-        handlers, &indices))
+    EXPECT_FALSE(
+        ArcNavigationThrottle::IsSwapElementsNeeded(handlers, &indices))
         << i;
 
     // When Chrome is not within the first |kMaxAppResults| elements, swap is
     // necessary.
     handlers = CreateArray(i, i - 1);
     indices.first = indices.second = 0;
-    EXPECT_TRUE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(handlers,
-                                                                      &indices))
+    EXPECT_TRUE(ArcNavigationThrottle::IsSwapElementsNeeded(handlers, &indices))
         << i;
     EXPECT_EQ(ArcNavigationThrottle::kMaxAppResults - 1u, indices.first) << i;
     EXPECT_EQ(i - 1, indices.second) << i;
   }
 
   for (size_t i = 0; i <= ArcNavigationThrottle::kMaxAppResults * 2; ++i) {
     // When Chrome does not exist in |handlers|, swap is unnecessary.
     mojo::Array<mojom::IntentHandlerInfoPtr> handlers = CreateArray(i, i);
-    EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
-        handlers, &indices))
+    EXPECT_FALSE(
+        ArcNavigationThrottle::IsSwapElementsNeeded(handlers, &indices))
         << i;
   }
 }
 
 }  // namespace arc