Ensure that Chrome is visible in the dialog by default

Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers| because the function is
for handling external protocols, but when the URL is intent: with a
fallback URL or geo:, it can be. When Chrome is in |handlers|, and 3
or more browser apps are also in |handlers|, there is a possibility
that Chrome is not visible in the dialog by default. This CL fixes
the issue by adjusting the position of Chrome in |handlers|.

BUG=654944
TEST=try, manually checked on cyan too.

Committed: https://crrev.com/6081895a1251c992f0c6a7a90406076139d17a47
Cr-Commit-Position: refs/heads/master@{#431373}

[Yusuke Sato, 2016-11-04 22:21:37]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 22:22:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 22:51:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:51:01]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-05 00:46:46]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 00:47:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-11-05 00:48:23]

Description was changed from

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers|, but when the URL
is intent: with a fallback URL or geo:, it can be.

BUG=None
TEST=try
==========

to

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers|, but when the URL
is intent: with a fallback URL or geo:, it can be.

BUG=654944
TEST=try
==========

[commit-bot: I haz the power, 2016-11-05 01:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 01:17:45]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-05 01:17:48]

yusukes@chromium.org changed reviewers:
+ djacobo@google.com, lhchavez@chromium.org

[Yusuke Sato, 2016-11-05 01:18:04]

PTAL too

[Yusuke Sato, 2016-11-05 01:19:26]

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
(right):

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc:389: size_t
chrome_app_index = 0;
moved the function as-is. no change.

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
(right):

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h:75: // Swaps
Chrome app with any app in row |kMaxAppResults-1| iff its index is
copied the comment from .cc as-is.

[Yusuke Sato, 2016-11-05 03:26:23]

Description was changed from

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers|, but when the URL
is intent: with a fallback URL or geo:, it can be.

BUG=654944
TEST=try
==========

to

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers| because the function is
for handling external protocols, but when the URL is intent: with a
fallback URL or geo:, it can be. When Chrome is in |handlers|, and 3
or more browser apps are also in |handlers|, there is a possibility
that Chrome is not visible in the dialog by default. This CL fixes
the issue by adjusting the position of Chrome in |handlers|.

BUG=654944
TEST=try, manually checked on cyan too.
==========

[djacobo_, 2016-11-05 04:49:21]

lgtm I may have misunderstood a detail in the comments, please check my note :)

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
(right):

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc:333:
// to ensure Chrome is not visible in the UI by defalult. Since This function
"to ensure Chrome IS visible..." , right?

[Yusuke Sato, 2016-11-07 17:11:36]

PTAL

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
(right):

https://codereview.chromium.org/2478923002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc:333:
// to ensure Chrome is not visible in the UI by defalult. Since This function
On 2016/11/05 04:49:21, djacobo wrote:
> "to ensure Chrome IS visible..." , right?

oops, good catch. Fixed.

[Yusuke Sato, 2016-11-08 19:09:43]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:10:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 19:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 19:59:06]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-11-10 21:22:59]

lgtm

oops, clicked the wrong button.

[Yusuke Sato, 2016-11-10 21:23:31]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-11-10 21:23:31]

The patchset sent to the CQ was uploaded after l-g-t-m from djacobo@google.com
Link to the patchset: https://codereview.chromium.org/2478923002/#ps40001
(title: "address review comment")

[commit-bot: I haz the power, 2016-11-10 21:24:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:06:53]

Description was changed from

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers| because the function is
for handling external protocols, but when the URL is intent: with a
fallback URL or geo:, it can be. When Chrome is in |handlers|, and 3
or more browser apps are also in |handlers|, there is a possibility
that Chrome is not visible in the dialog by default. This CL fixes
the issue by adjusting the position of Chrome in |handlers|.

BUG=654944
TEST=try, manually checked on cyan too.
==========

to

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers| because the function is
for handling external protocols, but when the URL is intent: with a
fallback URL or geo:, it can be. When Chrome is in |handlers|, and 3
or more browser apps are also in |handlers|, there is a possibility
that Chrome is not visible in the dialog by default. This CL fixes
the issue by adjusting the position of Chrome in |handlers|.

BUG=654944
TEST=try, manually checked on cyan too.
==========

[commit-bot: I haz the power, 2016-11-10 22:06:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-10 23:10:05]

Description was changed from

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers| because the function is
for handling external protocols, but when the URL is intent: with a
fallback URL or geo:, it can be. When Chrome is in |handlers|, and 3
or more browser apps are also in |handlers|, there is a possibility
that Chrome is not visible in the dialog by default. This CL fixes
the issue by adjusting the position of Chrome in |handlers|.

BUG=654944
TEST=try, manually checked on cyan too.
==========

to

==========
Ensure that Chrome is visible in the dialog by default

Usually Chrome is not included in |handlers| because the function is
for handling external protocols, but when the URL is intent: with a
fallback URL or geo:, it can be. When Chrome is in |handlers|, and 3
or more browser apps are also in |handlers|, there is a possibility
that Chrome is not visible in the dialog by default. This CL fixes
the issue by adjusting the position of Chrome in |handlers|.

BUG=654944
TEST=try, manually checked on cyan too.

Committed: https://crrev.com/6081895a1251c992f0c6a7a90406076139d17a47
Cr-Commit-Position: refs/heads/master@{#431373}
==========

[commit-bot: I haz the power, 2016-11-10 23:10:06]

Patchset 3 (id:??) landed as
https://crrev.com/6081895a1251c992f0c6a7a90406076139d17a47
Cr-Commit-Position: refs/heads/master@{#431373}