Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2478903002: DRP metrics observer stop observing after hidden (Closed)
Patch Set: bmcquade comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 // Observer responsible for recording core page load metrics releveant to 46 // Observer responsible for recording core page load metrics releveant to
47 // DataReductionProxy. 47 // DataReductionProxy.
48 class DataReductionProxyMetricsObserver 48 class DataReductionProxyMetricsObserver
49 : public page_load_metrics::PageLoadMetricsObserver { 49 : public page_load_metrics::PageLoadMetricsObserver {
50 public: 50 public:
51 DataReductionProxyMetricsObserver(); 51 DataReductionProxyMetricsObserver();
52 ~DataReductionProxyMetricsObserver() override; 52 ~DataReductionProxyMetricsObserver() override;
53 53
54 // page_load_metrics::PageLoadMetricsObserver: 54 // page_load_metrics::PageLoadMetricsObserver:
55 ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
56 const GURL& currently_committed_url,
57 bool started_in_foreground) override;
55 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override; 58 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
59 ObservePolicy OnHidden(
60 const page_load_metrics::PageLoadTiming& timing,
61 const page_load_metrics::PageLoadExtraInfo& info) override;
56 void OnComplete(const page_load_metrics::PageLoadTiming& timing, 62 void OnComplete(const page_load_metrics::PageLoadTiming& timing,
57 const page_load_metrics::PageLoadExtraInfo& info) override; 63 const page_load_metrics::PageLoadExtraInfo& info) override;
58 void OnDomContentLoadedEventStart( 64 void OnDomContentLoadedEventStart(
59 const page_load_metrics::PageLoadTiming& timing, 65 const page_load_metrics::PageLoadTiming& timing,
60 const page_load_metrics::PageLoadExtraInfo& info) override; 66 const page_load_metrics::PageLoadExtraInfo& info) override;
61 void OnLoadEventStart( 67 void OnLoadEventStart(
62 const page_load_metrics::PageLoadTiming& timing, 68 const page_load_metrics::PageLoadTiming& timing,
63 const page_load_metrics::PageLoadExtraInfo& info) override; 69 const page_load_metrics::PageLoadExtraInfo& info) override;
64 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing, 70 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing,
65 const page_load_metrics::PageLoadExtraInfo& info) override; 71 const page_load_metrics::PageLoadExtraInfo& info) override;
(...skipping 10 matching lines...) Expand all
76 const page_load_metrics::PageLoadExtraInfo& info) override; 82 const page_load_metrics::PageLoadExtraInfo& info) override;
77 void OnFirstMeaningfulPaint( 83 void OnFirstMeaningfulPaint(
78 const page_load_metrics::PageLoadTiming& timing, 84 const page_load_metrics::PageLoadTiming& timing,
79 const page_load_metrics::PageLoadExtraInfo& info) override; 85 const page_load_metrics::PageLoadExtraInfo& info) override;
80 void OnParseStart(const page_load_metrics::PageLoadTiming& timing, 86 void OnParseStart(const page_load_metrics::PageLoadTiming& timing,
81 const page_load_metrics::PageLoadExtraInfo& info) override; 87 const page_load_metrics::PageLoadExtraInfo& info) override;
82 void OnParseStop(const page_load_metrics::PageLoadTiming& timing, 88 void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
83 const page_load_metrics::PageLoadExtraInfo& info) override; 89 const page_load_metrics::PageLoadExtraInfo& info) override;
84 90
85 private: 91 private:
92 // Sends the page load information to the pingback client.
93 void SendPingback(const page_load_metrics::PageLoadTiming& timing,
94 const page_load_metrics::PageLoadExtraInfo& info);
95
86 // Gets the default DataReductionProxyPingbackClient. Overridden in testing. 96 // Gets the default DataReductionProxyPingbackClient. Overridden in testing.
87 virtual DataReductionProxyPingbackClient* GetPingbackClient() const; 97 virtual DataReductionProxyPingbackClient* GetPingbackClient() const;
88 98
89 // Data related to this navigation. 99 // Data related to this navigation.
90 std::unique_ptr<DataReductionProxyData> data_; 100 std::unique_ptr<DataReductionProxyData> data_;
91 101
92 // The browser context this navigation is operating in. 102 // The browser context this navigation is operating in.
93 content::BrowserContext* browser_context_; 103 content::BrowserContext* browser_context_;
94 104
95 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver); 105 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
96 }; 106 };
97 107
98 } // namespace data_reduction_proxy 108 } // namespace data_reduction_proxy
99 109
100 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_ 110 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698