Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2478893002: Revert of Support floating-point audio output for Windows7+ (Closed)

Created:
4 years, 1 month ago by Jamie Madill
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support floating-point audio output for Windows7+ (patchset #4 id:60001 of https://codereview.chromium.org/2475453003/ ) Reason for revert: Seems to have broken Windows GPU bots. Examples: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/7761 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28AMD%29/builds/43 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/25111 Original issue's description: > Support floating-point audio output for Windows7+ > > Instead of converting audio to 16-bit PCM, pass the audio data > as floating-point directly on the low-latency path (WASAPI) > > BUG=659641 > TEST=Run test url from bug and set gain to 0.00002 and hear output > > Committed: https://crrev.com/70fe19f8a20761c939444f2d3b8c6d1daf13c975 > Cr-Commit-Position: refs/heads/master@{#429928} TBR=dalecurtis@chromium.org,tommi@chromium.org,rtoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659641 Committed: https://crrev.com/ae586bc923a3b81870809fc9a77b78c4d58bcc0a Cr-Commit-Position: refs/heads/master@{#430003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M media/audio/win/audio_low_latency_output_win.cc View 6 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jamie Madill
Created Revert of Support floating-point audio output for Windows7+
4 years, 1 month ago (2016-11-04 20:33:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478893002/1
4 years, 1 month ago (2016-11-04 20:34:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 20:37:17 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 20:39:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae586bc923a3b81870809fc9a77b78c4d58bcc0a
Cr-Commit-Position: refs/heads/master@{#430003}

Powered by Google App Engine
This is Rietveld 408576698