Chromium Code Reviews
DescriptionRevert of Support floating-point audio output for Windows7+ (patchset #4 id:60001 of https://codereview.chromium.org/2475453003/ )
Reason for revert:
Seems to have broken Windows GPU bots. Examples:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Release%20%28NVIDIA%29/builds/7761
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28AMD%29/builds/43
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/25111
Original issue's description:
> Support floating-point audio output for Windows7+
>
> Instead of converting audio to 16-bit PCM, pass the audio data
> as floating-point directly on the low-latency path (WASAPI)
>
> BUG=659641
> TEST=Run test url from bug and set gain to 0.00002 and hear output
>
> Committed: https://crrev.com/70fe19f8a20761c939444f2d3b8c6d1daf13c975
> Cr-Commit-Position: refs/heads/master@{#429928}
TBR=dalecurtis@chromium.org,tommi@chromium.org,rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659641
Committed: https://crrev.com/ae586bc923a3b81870809fc9a77b78c4d58bcc0a
Cr-Commit-Position: refs/heads/master@{#430003}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||