Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: test/cctest/test-parsing.cc

Issue 2478883002: Remove always-true --harmony-restrictive-declarations flag (Closed)
Patch Set: Formatting Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser-base.h ('k') | test/mjsunit/es6/sloppy-restrictive-block-function.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index e915764355cc01c3c4da4eac3b660199c3f3525e..2bd6d47ebb4bf246c8686049c8336e766d051b10 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1291,7 +1291,6 @@ enum ParserFlag {
kAllowLazy,
kAllowNatives,
kAllowHarmonyFunctionSent,
- kAllowHarmonyRestrictiveDeclarations,
kAllowHarmonyAsyncAwait,
kAllowHarmonyRestrictiveGenerators,
kAllowHarmonyTrailingCommas,
@@ -1311,8 +1310,6 @@ void SetParserFlags(i::ParserBase<Traits>* parser,
parser->set_allow_natives(flags.Contains(kAllowNatives));
parser->set_allow_harmony_function_sent(
flags.Contains(kAllowHarmonyFunctionSent));
- parser->set_allow_harmony_restrictive_declarations(
- flags.Contains(kAllowHarmonyRestrictiveDeclarations));
parser->set_allow_harmony_async_await(
flags.Contains(kAllowHarmonyAsyncAwait));
parser->set_allow_harmony_restrictive_generators(
@@ -7645,11 +7642,6 @@ TEST(FunctionDeclarationError) {
// Invalid in all contexts
const char* error_data[] = {
"try function foo() {} catch (e) {}",
- NULL
- };
- // Valid in sloppy mode only, and only when the
- // --harmony-restrictive-declarations flag is off
- const char* unrestricted_data[] = {
"do function foo() {} while (0);",
"for (;false;) function foo() {}",
"for (var i = 0; i < 1; i++) function f() { };",
@@ -7681,8 +7673,7 @@ TEST(FunctionDeclarationError) {
// "{ function* f() {} function f() {} }",
NULL
};
- // Valid only in sloppy mode, with or without
- // --harmony-restrictive-declarations
+ // Valid only in sloppy mode.
const char* sloppy_data[] = {
"if (true) function foo() {}",
"if (false) {} else function f() { };",
@@ -7693,30 +7684,13 @@ TEST(FunctionDeclarationError) {
};
// clang-format on
- static const ParserFlag restrictive_flags[] = {
- kAllowHarmonyRestrictiveDeclarations};
-
// Nothing parses in strict mode without a SyntaxError
RunParserSyncTest(strict_context, error_data, kError);
- RunParserSyncTest(strict_context, error_data, kError, NULL, 0,
- restrictive_flags, arraysize(restrictive_flags));
- RunParserSyncTest(strict_context, unrestricted_data, kError);
- RunParserSyncTest(strict_context, unrestricted_data, kError, NULL, 0,
- restrictive_flags, arraysize(restrictive_flags));
RunParserSyncTest(strict_context, sloppy_data, kError);
- RunParserSyncTest(strict_context, sloppy_data, kError, NULL, 0,
- restrictive_flags, arraysize(restrictive_flags));
- // In sloppy mode, some things are successful, depending on the flag
+ // In sloppy mode, sloppy_data is successful
RunParserSyncTest(sloppy_context, error_data, kError);
- RunParserSyncTest(sloppy_context, error_data, kError, NULL, 0,
- restrictive_flags, arraysize(restrictive_flags));
- RunParserSyncTest(sloppy_context, unrestricted_data, kSuccess);
- RunParserSyncTest(sloppy_context, unrestricted_data, kError, NULL, 0,
- restrictive_flags, arraysize(restrictive_flags));
RunParserSyncTest(sloppy_context, sloppy_data, kSuccess);
- RunParserSyncTest(sloppy_context, sloppy_data, kSuccess, restrictive_flags,
- arraysize(restrictive_flags));
}
TEST(ExponentiationOperator) {
« no previous file with comments | « src/parsing/parser-base.h ('k') | test/mjsunit/es6/sloppy-restrictive-block-function.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698