Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2478883002: Remove always-true --harmony-restrictive-declarations flag (Closed)

Created:
4 years, 1 month ago by adamk
Modified:
4 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove always-true --harmony-restrictive-declarations flag The flag has been on since at least Chrome 53. R=littledan@chromium.org Committed: https://crrev.com/010770085b55260245797b23bdae2076b736d0d9 Cr-Commit-Position: refs/heads/master@{#40780}

Patch Set 1 #

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -520 lines) Patch
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/parsing/parser-base.h View 5 chunks +5 lines, -12 lines 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +2 lines, -28 lines 0 comments Download
A + test/mjsunit/es6/sloppy-restrictive-block-function.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/sloppy-implicit-block-function.js View 1 chunk +0 lines, -97 lines 0 comments Download
D test/mjsunit/harmony/sloppy-restrictive-block-function.js View 1 chunk +0 lines, -52 lines 0 comments Download
D test/mjsunit/regress/regress-220.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/mjsunit/regress/regress-536751.js View 1 chunk +0 lines, -11 lines 0 comments Download
D test/mjsunit/regress/regress-542099.js View 1 chunk +0 lines, -18 lines 0 comments Download
D test/mjsunit/regress/regress-542100.js View 1 chunk +0 lines, -25 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check.js View 2 chunks +1 line, -3 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
D test/webkit/function-declaration-statement.js View 1 chunk +0 lines, -185 lines 0 comments Download
D test/webkit/function-declaration-statement-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
adamk
4 years, 1 month ago (2016-11-04 18:13:39 UTC) #1
Dan Ehrenberg
lgtm
4 years, 1 month ago (2016-11-04 18:14:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478883002/1
4 years, 1 month ago (2016-11-04 18:15:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27903)
4 years, 1 month ago (2016-11-04 18:20:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478883002/20001
4 years, 1 month ago (2016-11-04 18:22:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 18:50:29 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:40 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/010770085b55260245797b23bdae2076b736d0d9
Cr-Commit-Position: refs/heads/master@{#40780}

Powered by Google App Engine
This is Rietveld 408576698